Consider using the administration theme when editing or creating content by default

Tagging for framework manager for their thoughts.

Personally I would not like to see this happen as I think this goes against the work done for claro.

Personally I would not like to see this happen as I think this goes against the work done for claro.

How so? Changing this would make it so Claro is used in even more situations, right?

Having a terrible case of the Mondays and no coffee. You are correct, some reason I read it as using the front end theme by default.

That's my mistake. Will mark it and see what the committer says.

I think Drupal may have been a system where using the frontend theme was the sensible default, but its used for more ambitious projects now and using the admin theme by default fits with that better. (Content types are more complex and usually other admin tasks are involved in creating the content, such as category management or media management).

I don't think this actually needs a framework manager review so removing the tag.

Something we still need to do is to go through tests where $this->config('node.settings')->set('use_admin_theme', '1') is being called to make sure that we are not changing any tests to not test what they are supposed to test.

Yeah it'd be good to know if we have explicit test coverage around this setting. Plus we'll need a CR to announce the change to people.

+1 for the change.

Searching for

->config('node.settings')->set('use_admin_theme',

There are 4 instances and 3 I believe can be removed.

ConfigurableLanguageManagerTest
AddedStylesheetsTest
ShortcutLinksTest

As far as a dedicated test where would that go?

https://www.drupal.org/node/3514929 → CR added

Rebased the MR against 11.x, will do a sniff round tests.

Resulted in a nice bit of tidy up.

The RecipeRunnerTest::testModuleConfigurationOverride test case specifically tested overriding this setting via a recipe so I've reversed the recipe's settings so the test is still testing that the recipe overrides node's default.

Failures appear to be random.

Believe feedback has been addressed.

Makes sense to me, and only flipping a default. We've got +1s from two product managers on this issue but because it was a while ago I pinged and @Gabor confirmed his was still valid.

Committed/pushed to 11.x, thanks!

catch → closed merge request !3618

Automatically closed - issue fixed for 2 weeks with no activity.