Offer to co-maintain Fivestar

The majority of the work is in 📌 Drupal 10 compatibility fixes Fixed , and issues linked from there.

Its been 2 weeks. I got no response from my PM to current maintainers. Re-assigning.

heddn,
thank you for offering to help out co-maintaining this!

The present owner is probably gone, but the project's other maintainers are still around. We need to hear their opinion about this. I've sent a PM asking for them to comment here:

Co-maintainer-offer for Fivestar

Hi, I am a site moderator at Drupal.org.
A maintainer-offer for Fivestar has been posted.
Please see:
https://www.drupal.org/project/projectownership/issues/3386131 💬 Offer to co-maintain Fivestar Postponed: needs info
and respond.

You may reject or accept the offer, but a public response will be appreciated.
If there is no response, heddn will be added as a co-maintainer by the site moderators in about two weeks time.

This PM is sent to all maintainers with the "Administer maintainers" permission.

For the maintainership offer process, please see: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

Postponing for now. Please set back to “Active” if there is no response in 14 days.

It would be nice with a https://www.reddit.com/r/RemindMeBot/ feature on drupal.org, allowing you to add a RemindMe! 14 Days comment, and alert you after that amount of time.

Alternatively, a new "Postponed 14 days" Status could serve the same purpose, and alert the issue subscribers two weeks after the Status was changed to this status.

Any request for new features at Drupal.org should go to the Drupal.org customizations → issue queue.

And people sometimes find an alternative solution within the 14 day waiting period, and choose not to pursue the matter. If they actually have a need for becoming maintainer in order to fix some project they actually use, I m sure they will remember.

Anyway, most people these day have smartphones with built-in calendars and reminders. Seems a bit redundant to expend manpower to get this feature added to Drupal.org.

I created ✨ Add RemindMeBot feature Active .

For some reason, @gisle mail was lost in the span. I've just noticed it.

Thanks for the offer!
I've added all the necessary permissions for @heddn :)

init90, thank you for bring a new maintainer onboard.

@gisle: "I've sent a PM asking for them to comment here"
Please check your script - I did not receive any PM from you.

Yes, Fivestar needs help from people to review patches, write documentation, answer support questions, triage the issue queue, write patches, fix the CSS, and most importantly help finish the incomplete port from D7 to D8+ that resulted in damaged features, lost features, lost testing, etc. For years I have repeatedly asked in the issue queue for help with these, with little to no response.

But none of that requires maintainer privileges. The only people who have been doing any of that over the years are already maintainers. And I have seen none of that from the person making this request.

What we do NOT need is someone to come in and just make one or two commits for their own benefit, then walk away and leave the other maintainers to deal with the consequences. We also do not need the repeated posts of automated (and wrong) patches from automated scripts run by people who do not read the issue comments or reply to the maintainer reviews. The module needs work BECAUSE of all the hacks and the shortcuts that were applied to the legacy code - that is why we have missing/broken features and dead code and untested functionality etc. Doing more of this is just going to make the problems worse.

This module is being maintained, but part of a maintainer's job is to say no to bad "fixes" and to explain in detail why they are bad. I think I have done this. Some just don't like that answer, and this seems more like an effort to circumvent what the maintainer is trying to do than an effort to help out.

Cross post, I didn't mean to change the status.

But after considering it, I do want to change the status.

@init90 is a maintainer, so he can do what he wants, but I am the one who has been doing most of the work for the past three years. I did an enormous amount of work on this module to fix the incomplete D7->D8 port, then to port to D9 and keep the code current against the evolving core version including all the work being done on D10. This module also depends on the Voting API module, where a similar
situation exists and where I also volunteered a lot of effort to put things back on track.

I do not think this approval was a good thing.

TR, I am not using a script to send these emails. I visit the user's profile on Drupal.org, click on the "Contact" tab and copypaste the text into the form. Then I click on "Send message". I am sure I send one to you along with the others, as documented in the issue summary. Please check your spam folder.

As for the approval that was done, this is for the project's team to sort out among themselves.

The motivation behind heddn's offer to co-maintain is that EOL for Drupal 9 is scheduled for November this year, and that issues to make the project Drupal 10 compatible exist in the issue queue, but were not addressed by any of the project's current maintainers. heddn posted the offer in the project's own issue queue, and that offer were also ignored for more than two weeks, indicating that nobody was around to monitor the project's issue queue. Nothing happened until heddn asked for help from the site moderators, according to the standard procedure for projects were the issue queue appears to no longer be monitored, and I started contacting the current maintainers by means of PM, to which one of the project's maintainers responded by adding heddn to the team.

Hi TR!

Thank you for three years development, BUT

1) Drupal 10 is here
2) We (community) make a patch which is working
3) You ignored us
4) I asked you in https://www.drupal.org/project/fivestar/issues/3287600#comment-15213253 📌 Drupal 10 compatibility fixes Fixed
5) You ignored again
6) I agree with "just make one or two commits for their own benefit, then walk away and leave", but a lot of people are waiting for a new release of Fivestar with D10 support and you ignored us

I've been fairly pressed on another client project (which doesn't require fivestar) for the past 48 hours and haven't had a chance to jump into the discussion here until now. My goal here is D10 support. If we can get D10 support hammered out for fivestar and in the process we don't need to add another maintainer, that's perfectly fine with me.

Based on the discussion since maintainership was granted in #8, I'm not sure what my next steps should be. I really don't want to inject myself into a firestorm. One of the first things I propose to do for D10 support is to triage the existing related tickets and see which are strictly required and the minimal steps needed to get to that threshold. Once those issues are identified, I would like to systematically review all the opened patches/MR and commit as much of the low hanging fruit as possible. After low hanging fruit is knocked out, then we can focus on the (hopefully) one or 2 more complicated issues and get those handled in short order. All before our impending November date as aptly pointed out by @gisle in #13.

Does that seem like a good plan to move forward?

TR,
you set this issue back to "Active", but it is unclear why you did so.

What activity do you expect to see here?

As far as the site moderators are concerned, this issue has been resolved and its status should be set to "Fixed".

I understand that you're unhappy with the decision taken about one of the other maintainers on the project, but unless there is a clear reason for keeping this "Active" I am going to change the status in a couple of days.

Since this issue has received a reply from a maintainer, who added heddn as maintainer (not as co-maintainer as requested) this is now an issue for the project queue.

I think more insight from @init90 and @TR might be helpful.

What we do NOT need is someone to come in and just make one or two commits for their own benefit, then walk away and leave the other maintainers to deal with the consequences. We also do not need the repeated posts of automated (and wrong) patches from automated scripts run by people who do not read the issue comments or reply to the maintainer reviews. The module needs work BECAUSE of all the hacks and the shortcuts that were applied to the legacy code - that is why we have missing/broken features and dead code and untested functionality etc. Doing more of this is just going to make the problems worse.

And almost a year later it turns out that's exactly what happened.

I'm not looking forward to having to clean this up in addition to all the normal work that needs to be done.