The configuration synchronization page encounters errors when core.extension.yml is missing in the config/sync directory.

joegraduate → changed the visibility of the branch 3385934-configuration-synchronization-page to hidden.

joegraduate → changed the visibility of the branch 3385934-configuration-synchronization-page to active.

Looks like the target branch for the MR needs to be updated to to 11.x

I cherry-picked @useernamee's commit into a new branch based on 11.x and created a new MR targeting 11.x

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Thanks for working on this issue.

Will need a failing test case to show the issue.

phthlaap → changed the visibility of the branch 3385934-configuration-synchronization-page to hidden.

This GitLab "Test-only changes" pipeline in MR !7103 fails as expected as of @phthlaap's latest changes:

PHPUnit 9.6.15 by Sebastian Bergmann and contributors.
Testing Drupal\Tests\field\Functional\FieldImportDeleteUninstallUiTest
.
E                                                                  2 / 2 (100%)
Time: 00:16.901, Memory: 4.00 MB
There was 1 error:
1) Drupal\Tests\field\Functional\FieldImportDeleteUninstallUiTest::testSynchronizeForm
Behat\Mink\Exception\ExpectationException: Current response status code is 500, but 200 expected.
/builds/issue/drupal-3385934/vendor/behat/mink/src/WebAssert.php:888
/builds/issue/drupal-3385934/vendor/behat/mink/src/WebAssert.php:145
/builds/issue/drupal-3385934/core/modules/field/tests/src/Functional/FieldImportDeleteUninstallUiTest.php:143
/builds/issue/drupal-3385934/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
ERRORS!
Tests: 2, Assertions: 28, Errors: 1.

So I tried to replicate locally by emptying my config/sync folder and going to /admin/config/development/configuration but I don't get any error or see anything in the logs.

Could additional steps be added to the issue summary.

@smustgrave just remove the file core.extension.yml instead of all .yml files

Title and issue summary should be updated to reflect the issue.

Title and issue summary have both been updated.

Seems like an edge case but definitely do see the issue, tests also show it

1) Drupal\Tests\field\Functional\FieldImportDeleteUninstallUiTest::testSynchronizeForm
Behat\Mink\Exception\ExpectationException: Current response status code is 500, but 200 expected.
/builds/issue/drupal-3385934/vendor/behat/mink/src/WebAssert.php:888
/builds/issue/drupal-3385934/vendor/behat/mink/src/WebAssert.php:145
/builds/issue/drupal-3385934/core/modules/field/tests/src/Functional/FieldImportDeleteUninstallUiTest.php:143
/builds/issue/drupal-3385934/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
ERRORS!
Tests: 2, Assertions: 28, Errors: 1.

Tried to see if there is a better spot to put this test but anywhere else felt like a stretch for any other test function.

Think this should be good.

I feel this fix is in the wrong place. If core.extension is missing we should have bailed way before hitting hook_config_import_steps_alter.

Given the importance of core.extension I think we can add something to \Drupal\system\SystemConfigSubscriber::onConfigImporterValidateNotEmpty like

    if (!isset($importList['core.extension')) {
      $event->getConfigImporter()->logError($this->t('This import does not contain core.extension configuration, so has been rejected.'));
    }

Eventually schema validation is going to do this for us.

pradhumanjain2311 → made their first commit to this issue’s fork.

#27 It will impact the import configuration form when there are no changes in the core extension.

Ahh interesting... must have forgotten something along the way... posted a formulation on the MR that will work...

Keshav Patel → made their first commit to this issue’s fork.

@alexpott the core.extension configuration is validated in core/lib/Drupal/Core/EventSubscriber/ConfigImportSubscriber.php:93. I think we no need to validate again.

    $config_importer = $event->getConfigImporter();
    if ($config_importer->getStorageComparer()->getSourceStorage()->exists('core.extension')) {
      $this->validateModules($config_importer);
      $this->validateThemes($config_importer);
      $this->validateDependencies($config_importer);
    }
    else {
      $config_importer->logError($this->t('The core.extension configuration does not exist.'));
    }

It also have test cases to cover: core/tests/Drupal/KernelTests/Core/Config/ConfigImporterTest.php::testMissingCoreExtension

But even when it is validated I think we also need fix the core/modules/field/field.module:324 to prevent the TypeError message when access the page /admin/config/development/configuration

Re-ran test-only feature https://git.drupalcode.org/issue/drupal-3385934/-/jobs/1326634 which shows the test is still covering the change.

Believe the feedback from @alexpott has been addressed

I did save credit for the users who have worked on the issue, did not include just applying a suggestion.

Committed to 11.x and backported to 11.0.x, 10.4.x and 10.3.x

larowlan → closed merge request !7103

Automatically closed - issue fixed for 2 weeks with no activity.