Create an InputStreamFileWriter for writing the input stream to a file

Remaining tasks:

• Add usage in REST
• Add usage in JSON API

• Added usage for REST
• Added usage for JSON API

A couple of remaining tasks:

• Add a change record
• Add deprecations

Added a change record. There is nothing to deprecate as we are just replacing usage in protected methods.

Change looks good. Updated CR to include the name of the new service.

I'm triaging RTBC issues → . I read the IS, the comments and the comments in the MR. I didn't find any unanswered questions or other work to do.

Leaving at RTBC.

Working through all the issues under 📌 [META] Modernise file upload logic Active the name "uploader" is a very over-used term. Using it here "StreamFileUploader" is a bit confusing. I think InputStreamFileWriter::writeStreamToFile() is a much clearer name to describe what it does.

Updated the code, issue title & summary and change record to match.

Blocking a critical 📌 [PP-4] Unify file upload logic of REST and JSON:API Postponed therefore this is also critical.

@kim.pepper, thanks for not adding more instances of the word 'uploaders'. That word is in dictionary.txt and we are trying to remove all the misspellings from that file.

This needs a reroll.

Conceptually it looks like a great cleanup, duplicated code from the two modules is consolidated. This probably should have happened before JSON:API went into core, but better late than never.

Re-rolled.

Left some comments on the MR

Resolved feedback.

Bummer about missing 10.2 but feedback appears to have been addressed.

Committed to 11.x and published the change record.

Thanks!

kim.pepper → closed merge request !4573

Automatically closed - issue fixed for 2 weeks with no activity.

We forgot to update the CR links in the deprecation trigger. Created 🐛 Fix incorrect change record link in FileUploadResource and TemporaryJsonapiFileFieldUploader constructors Needs review

Created another follow up for deprecating BYTES_TO_READ 📌 Deprecate unused constant BYTES_TO_READ in FileUploadResource and TemporaryJsonapiFileFieldUploader Needs review