- Issue created by @kim.pepper
- Merge request !6233Issue #3415706 Deprecate unused constant BYTES_TO_READ → (Closed) created by kim.pepper
- Status changed to Needs review
11 months ago 11:50pm 18 January 2024 - Status changed to Needs work
11 months ago 2:48pm 22 January 2024 - 🇺🇸United States smustgrave
Believe this will need it's own CRs. The links being added are already published.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I don't think they need their own CRs. It's part of the same change. Adding to a change record is fine IMO.
- Status changed to Needs review
11 months ago 9:07pm 29 January 2024 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Back to NR for #5. Happy to hear other opinions on this.
- Status changed to RTBC
11 months ago 3:39pm 30 January 2024 - Status changed to Needs work
11 months ago 5:26pm 30 January 2024 - 🇬🇧United Kingdom longwave UK
The REQUEST_HEADER_FILENAME_REGEX deprecation is changed here, that seems wrong,
Neither change record actually mentions what to do if you were using the old constants, it would be good to have a short note about that.
- Status changed to Needs review
11 months ago 8:44pm 30 January 2024 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Reverted the CR link change for
REQUEST_HEADER_FILENAME_REGEXand updated the CR to mention the deprecations and new location. - Status changed to Needs work
11 months ago 3:26pm 31 January 2024 - 🇺🇸United States smustgrave
Correct me if I'm wrong but shouldn't it be the same CR link?
- Status changed to Needs review
11 months ago 9:33pm 31 January 2024 - Status changed to RTBC
11 months ago 2:43pm 1 February 2024 -
longwave →
committed d0677640 on 11.x
Issue #3415706 by kim.pepper, smustgrave, longwave: Deprecate unused...
-
longwave →
committed d0677640 on 11.x
- Status changed to Fixed
11 months ago 5:01pm 3 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.
