- Issue created by @madhaze
- last update
about 1 year ago Custom Commands Failed - @madhaze opened merge request.
- πΊπΈUnited States madhaze
I put up an commit that is an attempt for this fix. It does address #1 in proposed solution and checks for focusable. It also addresses finding the triggering element. but not the way that was listed in #3 in proposed solution.
https://git.drupalcode.org/project/drupal/-/merge_requests/4568/diffs
- last update
about 1 year ago 29,450 pass, 1 fail - Status changed to Needs review
about 1 year ago 12:49am 11 August 2023 - last update
about 1 year ago 29,456 pass, 1 fail - Status changed to Needs work
about 1 year ago 12:06am 16 August 2023 - πΊπΈUnited States smustgrave
Thank you for reporting.
Should try and add a test case showing the issue.
Updated ticket to latest dev branch. MR should be updated as well.
Thanks
- last update
about 1 year ago 29,456 pass, 1 fail - last update
about 1 year ago 29,952 pass, 1 fail - @madhaze opened merge request.
- last update
about 1 year ago 30,388 pass, 1 fail - πΊπΈUnited States madhaze
Made update to MR. Added check to make sure class list was not empty before using for querySelector.
- π¬π§United Kingdom Lincoln-Batsirayi
@madhaze's patch didn't quite work for me because on our project we use tailwind which can have classes such as "lg:block" and because of this the line
target.querySelector(updatedSelector)
was failing because it didn't recognise these classes ".lg:block" as actual classes/selectors, as a result of this i added a line to replace the colons with "\\:" as that fixes the issue. I understand this might be an edge case but it might help other's who have a similar set up. - π¬π§United Kingdom Lincoln-Batsirayi
Re-uploading my patch so it includes all code, made an error on the last one