#2 patch worked for the issue I was seeing.
Fixed recursion happening on content type "Manage Display" for view modes using Layout Builder Restrictions. As well as the "Manage Layout" edit page.
Custom theme that is based on Stable9.
I don't have a vanilla drupal testing env. Needed to be able to post a patch. Thought it was a valid issue.
Was working when using clientside_validation with the patch mentioned above to fix this issue, but when enabled webforms_clientside_validation it overrides the file that was patched in clientside_validation. Tho webforms_clientside_validation did fix other functionality that was missing.
Adding the patch from the MR
Made update to MR. Added check to make sure class list was not empty before using for querySelector.
ChrisSnyder → credited madhaze → .
patch in #42 does need some updates.
- If adding label should the title attribute be removed. VoiceOver at least reads both
- "updateSelectAll" function would need to be updated to update the label instead of the title
- label /input should be placed in same order as other for consistency
- label should probably have 'visually-hidden' class to match other checkbox labels
Other checkboxes are using a label with `visually-hidden` should we match that or should they be updated to use `aria-label` instead?
The missing label on an input is getting flagged by accessibility scanning tools like Wave.
Alerts
Unlabeled form control with titleWhat It Means
A form control does not have a label, but has a title.Why It Matters
The title attribute value for unlabeled form controls will be presented to screen reader users. However, a properly associated text label provides better usability and accessibility and should be used unless the purpose of the form control is intuitive without the label.How to Fix It
If a visible text label is available for the form control, associate the text label to the form control using the label element. This provides additional functionality for end users because if the label is clicked it will set focus to the form control. If the form control is intuitive without a , the title attribute value may be used. Note that the title attribute value will not generally be read by a screen reader if the control has a label and may not be available to sighted users, particularly keyboard-only users.The Algorithm... in English
An (except types of image, submit, reset, button, or hidden), , or
element has a non-empty title attribute value and is missing a label or valid aria-labelledby reference.Code
<input type="checkbox" class="form-checkbox" title="Select all rows in this table">Standards and Guidelines
1.1.1 Non-text Content (Level A)
1.3.1 Info and Relationships (Level A)
2.4.6 Headings and Labels (Level AA)
3.3.2 Labels or Instructions (Level A) Icon index
The adding label to inputs is mentioned in https://www.drupal.org/project/drupal/issues/3082598 ✨ Add theme function for form labels in JavaScript Needs work
This would still be nice. It would also need to be added to tableselect.js so the checkbox there also has a label for accessibility. https://git.drupalcode.org/project/drupal/-/blob/11.x/core/misc/tablesel...
I'm not sure where the below checkbox input markup is created to be able to add an id and label for it.
<input type="checkbox" class="form-checkbox" title="Select all rows in this table">
madhaze → created an issue.
I put up an commit that is an attempt for this fix. It does address #1 in proposed solution and checks for focusable. It also addresses finding the triggering element. but not the way that was listed in #3 in proposed solution.
https://git.drupalcode.org/project/drupal/-/merge_requests/4568/diffs