Contrib.social

Radio button clientside validation text in the wrong place

Open on Drupal.org →
Created on 18 October 2023, 9 months ago
Updated 6 April 2024, 3 months ago

Problem/Motivation

The webform clientside validation for radio places the error message in the wrong place. It places the error message after the first radio or checkbox input. It should be added at the end of the fieldset the inputs are in.

@see https://www.drupal.org/project/webform/issues/3114436 → - mentions it is a clientside_validation issue and there is a patch for this with this issue in the clientside_validation module https://www.drupal.org/project/clientside_validation/issues/3166606 ✨ Improve #radios required validation and error placement. Needs work

Although in https://git.drupalcode.org/project/webform/-/blob/6.2.0-rc2/modules/webf... webform_clientside_validation is disabling cv.jquery.ife.js from clientside_validation. So we will need to update placement in `webform_clientside_validation/js/webform_clientside_validation.ife.js`.

Steps to reproduce

  1. enable `Clientside Validation, Clientside Validation jQuery, Webform Clientside Validation`
  2. add radios to form and make "required"
  3. turn on "Validate on Blur/focusout" in /admin/config/user-interface/clientside-validation-jquery-settings
  4. on form tab past radios

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: won't fix

Version

6.2

Component

Code

Created by

🇺🇸United States madhaze

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @madhaze
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update 9 months ago
    536 pass
  • @madhaze opened merge request.
  • Comment 9 months ago →
    🇺🇸United States madhaze

    Adding the patch from the MR

  • Status changed to Postponed: needs info 9 months ago
  • Comment 9 months ago →
    🇺🇸United States jrockowitz Brooklyn, NY

    What theme are you using?

    We need to be able to replicate the issue with an example webform to be able to properly fix it.

  • Status changed to Active 9 months ago
  • Comment 9 months ago →
    🇺🇸United States madhaze

    Custom theme that is based on Stable9.
    I don't have a vanilla drupal testing env. Needed to be able to post a patch. Thought it was a valid issue.

    Was working when using clientside_validation with the patch mentioned above to fix this issue, but when enabled webforms_clientside_validation it overrides the file that was patched in clientside_validation. Tho webforms_clientside_validation did fix other functionality that was missing.

  • Status changed to Closed: won't fix 3 months ago
  • Comment 3 months ago →
    🇺🇸United States jrockowitz Brooklyn, NY

    Since this is a custom theme related issue it should be fixed with custom code/patch.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024