[a11y] WCAG A violation: links must be distinguishable without relying on color

I am working on this issue.

Here is the patch for fixing this issue.
Attached screenshots for reference.

If I'm reading this patch correctly, it unconditionally styles all <a> tags. Can this be done with a less disruptive and wide-spread selector, e.g. something that tries to target links within running text?

Definitly not be perfect, but :where(p) a { text-decoration: underline; } or a:where(:not([class])) { text-decoration: underline; } should do it almost everywhere with a specifity of 0-0-1 and less side effects on existing admin UIs.

I'm not an accessability expert, but I don't think it is necessary to underline all links everywhere, stuff like <a class="button">, links in breadcrumbs, links in tabs, links in toolbars, links in table headers, links in views in their own table cell <td><a></td>,.... are all distinguishable without an underline.

@hudri sure, will check on this.

Hi i have applied patch for the following issue attached screenshots below. After patch adding underlines also format code in gin.css so that patch applied cleanly. And Issue is now fixed please check.

The above patch fails for me, also I have added a patch with a selector which will target all the a tags inside p which does not have any class, as needed as per the comment by @hudri.

I asked @aschaeggi about this on Slack to confirm the approach, since he designed Gin. He said he'd prefer a dotted underline.

hello @bnjmnm, added dotted underline as per the comment. Here is the updated patch and screenshot.

@snehal-chibde I have reviewed patch #10, applied successfully and dotted line working fine

MR !291 is ready to be reviewed

After applied MR !29 is local and it's resolved the issue.

I tested with multiple Accent color in different modes.

Shared attachment for reference.

Thanks!

Great thanks y'all for your work on this 👏

Automatically closed - issue fixed for 2 weeks with no activity.

..hm I came here because after update of Gin theme i can see dotted underline link which makes me crazy.

Would be possible to implement that config to theme seetings and disable it somehow ? I do really hate it now :D

@coaston we won't add a new setting to override this.

You have options to override styles from Gin but as this makes links inaccessible again I would not recommend doing so.

See https://www.drupal.org/docs/contributed-themes/gin-admin-theme/custom-th... →

Thank you for you clarification. Will need to accept it.