Contrib.social

Change hardcoded schema name "public" in SchemaTest::testPgsqlSequences

Open on Drupal.org →
Created on 27 July 2023, over 1 year ago
Updated 4 August 2023, over 1 year ago

Problem/Motivation

In 📌 [META] Fix @todo items referencing closed issues Active we've discovered there's a @todo in \Drupal\Tests\pgsql\Kernel\pgsql\SchemaTest::testPgsqlSequences.
This @todo is linked to an d.o. issue that is already closed: 🐛 Multiple issues when PostgreSQL is used with non-public schema Fixed .

This is the @todo:

    // @todo replace 'public.' with defaultSchema when issue https://www.drupal.org/i/1060476 lands.
    $this->assertEquals('public.' . $this->connection->getPrefix() . 'sequence_test_uid_seq', $sequence_name);

Steps to reproduce

Proposed resolution

Use $schema = $options['schema'] ?? 'public'; as introduced in 🐛 Multiple issues when PostgreSQL is used with non-public schema Fixed .

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

11.0 🔥

Component
PHPUnit  →

Last updated about 20 hours ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
  • PostgreSQL

    Particularly affects sites running on the PostgreSQL database.

Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024