Contrib.social

[META] Fix @todo items referencing closed issues

Open on Drupal.org →
Created on 31 March 2020, about 4 years ago
Updated 30 October 2023, 8 months ago

Problem/Motivation

I did some grepping to find @todo items that reference closed issues 

grep -r "@todo .*[\r\n]* https://.*drupal.org/.*" . | grep -o  '/[0-9]\+' | while read -r line ; do
     markup=$(curl --silent "https://www.drupal.org/node$line" | hxnormalize -x) 
     status=$(echo $markup |  hxselect '.field-name-field-issue-status .field-item' | sed 's/<\/\?[^>]\+>//g')
     if [[ "$status" == *"Closed"* ]]; then
       echo "[#$line]" | sed 's/\///g'
     fi
 done | uniq

39 were found on the initial run. These should be cleaned up.

Proposed resolution

Create child issues for each of the closed @todo items. In that child issue:

  • If it can be confirmed that the @todo is truly addressed in the referenced issue, follow the instructions of the @todo then remove it
  • If the circumstances of the @todo are not truly addressed, find out if the @todo should be referencing a different existing issue, or create a new one to address the needs of the @todo.
  • As issues are completed, update the issue summary to document that, so it's not neccessary to rely on drupal.org dynamically representing the issue status.

Many of these issues can get a novice tag, but this can be omitted if the solution seems like it will be more complex.

Remaining tasks

See if the search used to find these issues can be improved. If additional completed @todos are found, add them to the issue summary.

Follow the steps in proposed resolution. Create child issues and complete them, update the table below as they are updated/completed

@todo Fixed in a dedicated issue

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component
Other  →

Last updated about 24 hours ago

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024