- Issue created by @wim leers
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - @wim-leers opened merge request.
- last update
over 1 year ago 118 pass - last update
over 1 year ago 112 pass, 1 fail - Assigned to wim leers
- Status changed to Needs review
over 1 year ago 11:04am 26 July 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I expect this to fail like so:
1) Drupal\Tests\demo_umami\Functional\DemoUmamiProfileTest::testConfig Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ -Array &0 () +Array &0 ( + 0 => 'The current CKEditor 5 build requires the following elements and attributes: <br><code><br> <p> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id> <* dir="ltr rtl" lang> <cite> <dl> <dt> <dd> <a hreflang href> <blockquote cite> <ul type> <ol type start reversed> <img src alt data-entity-type data-entity-uuid data-align data-caption width height> <drupal-media data-view-mode title data-entity-type data-entity-uuid alt data-caption data-align> <strong> <em> <li>
The following elements are not supported:<img loading>
'
+ 1 => 'The current CKEditor 5 build requires the following elements and attributes:<br> <p> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id> <* dir="ltr rtl" lang> <cite> <dl> <dt> <dd> <a hreflang href> <blockquote cite> <ul type> <ol type start reversed> <img src alt data-entity-type data-entity-uuid data-align data-caption width height> <drupal-media data-view-mode title data-entity-type data-entity-uuid alt data-caption data-align> <strong> <em> <li>
The following elements are missing:<ol reversed>
'
+ 2 => 'Configuration for the enabled plugin "List" (ckeditor5_list) is missing.'
+ 3 => 'Configuration for the enabled plugin "Media" (media_media) is missing.'
+)
- last update
over 1 year ago 112 pass, 1 fail - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Now expecting
1) Drupal\Tests\demo_umami\Functional\DemoUmamiProfileTest::testConfig Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ -Array &0 () +Array &0 ( + 0 => 'The current CKEditor 5 build requires the following elements and attributes: <br> <p> <h2 id> <h3 id> <h4 id> <h5 id> <h6 id> <* dir="ltr rtl" lang> <cite> <dl> <dt> <dd> <a hreflang href> <blockquote cite> <ul type> <ol type start> <img src alt data-entity-type data-entity-uuid data-align data-caption width height> <drupal-media data-view-mode title data-entity-type data-entity-uuid alt data-caption data-align> <strong> <em> <li>The following elements are not supported: <img loading>' +)
Root cause: #3247795: Add text filter plugin to support and remove it from editor_file_reference → wanted to allow users of Basic HTML to override the
loading
attribute on<img>
, but didn't correctly upgrade the CKEditor 5 settings to actually allow it. - last update
over 1 year ago 118 pass - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 12:38pm 26 July 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Great, let's change the drupalci.yml back to the default.
- last update
over 1 year ago 29,879 pass - Status changed to Needs review
over 1 year ago 1:09pm 26 July 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Did that, and also applied it to the install profile as you requested in Slack. Note that for Minimal, I did not include the CKEditor 5 validation logic because Minimal has no configuration that enables CKEditor 5.
- Status changed to RTBC
over 1 year ago 2:02pm 26 July 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Great, this will hopefully make sure that every config we have in core that comes with an install profile is compliant with the schema's that underpin it. These tests will probably break when we increase the validation of the config schema's but this is a great way to keep those schema's in check.
- First commit to issue fork.
- last update
over 1 year ago 29,882 pass - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
#3247795: Add text filter plugin to support and remove it from editor_file_reference → is the answer to @lauriii's question.
- last update
over 1 year ago 29,885 pass - Status changed to Fixed
over 1 year ago 7:26pm 27 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.