Remove the password-confirm class from the pass2 password input

Issue created by @gauravvvv
Status changed to Needs review over 1 year ago2:56am 13 July 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
Custom Commands Failed
Comment over 1 year ago →
🇮🇳India gauravvvv Delhi, India
I have replaced password-confirm class with password-confirm-field, Also js-password-confirm with js-password-confirm-field

Please review
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,811 pass
Comment over 1 year ago →
🇮🇳India gauravvvv Delhi, India
Fixed the build failure, attached interdiff for same.
Status changed to Needs work over 1 year ago2:31pm 13 July 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Seems to be another instance in claro_preprocess_form_element__password_confirm
Status changed to Needs review over 1 year ago2:40pm 13 July 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,811 pass
Comment over 1 year ago →
🇮🇳India sakthi_dev
Please review.
Comment over 1 year ago →
🇮🇳India gauravvvv Delhi, India
@sakthi_dev, Please add interdiff with #3.
Status changed to RTBC over 1 year ago6:32pm 14 July 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Here's the interdiff missing from #5
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,815 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,815 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,822 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,842 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,878 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,881 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,885 pass
Status changed to Needs work over 1 year ago8:26am 29 July 2023

🇫🇮Finland lauriii Finland

--- a/core/lib/Drupal/Core/Render/Element/PasswordConfirm.php
+++ b/core/lib/Drupal/Core/Render/Element/PasswordConfirm.php

@@ -85,7 +85,7 @@ public static function processPasswordConfirm(&$element, FormStateInterface $for
-        'class' => ['password-confirm', 'js-password-confirm'],
+        'class' => ['password-confirm-field', 'js-password-confirm-field'],

This doesn't impact just Claro. We should either add a BC layer for this in Stable, or make the change in Claro theme.

Remove the password-confirm class from the pass2 password input

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities