Regression: infinite height prevention disables scrolling in Source view

@msbtterswrth,
This was a requirement to disable this scroll in https://ckeditor.com/old/forums/CKEditor-3.x/Disable-Scroll-Bar.
If you want to enable this, you can use this code in your custom css with some parent id.

.ck-source-editing-area textarea{
    overflow: visible;
}

This should work.

@shailja179, that forum post is for cke 3 from over 10 years ago.

This is a new issue that did not occur in cke4 in d8,d9 or d10. It is new to cke 5. Are you saying this is expected behavior? I can not see the full content of my source code within the editor currently without adding custom code.

I can certainly patch it locally, but this is already happening on three client sites, it seems like we should either fix this upstream by either fixing the height so we can see the entire contents or add a scroll back in like in cke4.

@shailja179 FYI should avoid assigning tickets to yourself unless you're a maintainer
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →

Should just leave a comment you'll be working on it

Seems like a valid bug so moving to Active as there is no patch yet.

Thanks!

Can confirm this is a valid bug and it is upstream, on their snippets site they alter the CSS to cater for it:

I propose we do the same thing in the core ckeditor5 module.

Here's a patch that solves the problem for Drupal 10. Suggestions on how to test this welcome, can't guarantee I'll have the time to create one.

Leaving NW for a test.

My IDE moved the 80 character line 🙄

https://github.com/ckeditor/ckeditor5/issues/10731 says this was fixed in October 2021?!

I investigated and found … that this is a regression introduced by ✨ CKEditor 5 should not grow to infinite height Fixed 😅

I tested the patch in #9 from @darvanen and that is working excellently for me! Not sure if there's anything else that needs to be done, but I marked it as RTBC. Thanks for the quick work friends!

Putting this back to NW because there isn't a test yet for it, my bad!

First attempt at a Nightwatch test, also it seems that testing if an element has scrollbars is not without it's own challenges.
(My implementation was based on https://stackoverflow.com/questions/4814398/how-can-i-check-if-a-scrollb...)

Defenitely needs some JavaScript-Jefe eyes on this.

That test does appear to reproduce the problem and accurately verify failure without the patch and success with! 👍

But … I still think this is the wrong solution.

+++ b/core/modules/ckeditor5/css/editor.css
@@ -19,3 +19,9 @@
+div.ck-source-editing-area textarea {

Compare this selector to the selector above: .ck-editor__main > :is(.ck-editor__editable, .ck-source-editing-area) {, which as I wrote in #10 is what introduced this bug (in ✨ CKEditor 5 should not grow to infinite height Fixed ).

AFAICT the selector should be more specific, I suspect this:

.ck-editor__main > .ck-source-editing-area textarea {

The .ck-editor__main > :is(.ck-editor__editable, .ck-source-editing-area) selector isn't directly affecting the text area. The text area is just inheriting an overflow: hidden from the injected styles for the editor.

Hm … summoning @lauriii 🤓

The selector proposed in #14 seems right based on the pre-existing selector 👍

You're very welcome 😁

I needed the library and it seemed daft not to contribute it.

The selectors from 14 will work too, there must be some kind of Drupal practice here I’m not aware of. I’m nowhere near my computer right now so I can’t update it.

Nicely done with that test too!

I’m nowhere near my computer right now so I can’t update it.

Never leave home without a computer...

Here's an updated patch, fail-patch stays the same.

Committed 91609ef and pushed to 11.x. Also cherry-picked to 10.1.x. Thanks!

Thanks for the fast work everyone! 🎉

Hi! We just ran into this issue and our client is asking about a fix. Before we go and apply this patch ourselves, is there a way to find out when a 10.1.2 release might be published containing this fix?

Thanks!

Looking at https://www.drupal.org/about/core/policies/core-release-cycles/schedule#... → (and replacing 10.0.x with 10.1.x, since the versions written there seem a tad outdated) 10.1.2 should be in a theatre/release near you around Aug. 2nd, so in 2 weeks.

Many thanks, Spokje! I was not sure whether the 10.0.x dates applied to 10.1.x.

Automatically closed - issue fixed for 2 weeks with no activity.

This was released yesterday, in https://www.drupal.org/project/drupal/releases/10.1.2 → 🚀