Fix the issues reported by phpcs

Created on 6 July 2023, over 1 year ago
Updated 13 June 2024, 6 months ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/pancard_number_widget/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------
10 | WARNING | [ ] Line exceeds 80 characters; contains 387 characters
12 | WARNING | [ ] Line exceeds 80 characters; contains 361 characters
14 | WARNING | [ ] Line exceeds 80 characters; contains 396 characters
28 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

Time: 89ms; Memory: 8MB

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pancard_number_widget/

Remaining tasks

Patch review

๐Ÿ“Œ Task
Status

RTBC

Version

1.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Ashutosh Ahirwal India

    Provided patch doesn't get apply throwing error.

    git apply -v coding-standard-fixes_18.patch
    coding-standard-fixes_18.patch:14: trailing whitespace.
    A PAN card (short for Permanent Account Number card) is a personal
    Checking patch README.md...
    error: while searching for:

    ## INTRODUCTION

    A PAN card (short for Permanent Account Number card) is a personal identification document issued by the Indian Income Tax Department to individuals and organizations in India. It is a 10-digit alphanumeric identification number that is unique to each individual or organization and is used for various purposes, such as filing income tax returns and conducting financial transactions.

    The PAN card is a laminated plastic card that contains the individual's or organization's name, date of birth (for individuals), and PAN number. It also contains a photograph of the individual (for individuals) and other identifying information. The PAN card is issued to individuals and organizations upon request and is valid for the lifetime of the holder.

    In India, the PAN card is an important document that is widely used for various purposes, such as opening a bank account, applying for a credit card, purchasing a vehicle or property, and conducting other financial transactions. It is also used as a valid proof of identity and address for various purposes, such as obtaining a passport, driver's license, and other government-issued documents.

    ## CONFIGURATION

    error: patch failed: README.md:7
    error: README.md: patch does not apply

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia rakesh.regar Rajasthan, India

    rakesh.regar โ†’ made their first commit to this issueโ€™s fork.

  • @rakeshregar opened merge request.
  • Status changed to Needs review about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia rakesh.regar Rajasthan, India

    MR raised, moving to needs review.

  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡ต๐Ÿ‡ญPhilippines clarkssquared

    Hi rakesh,

    I applied your MR !3 and it looks likes it fails to apply,

    I used two methods in applying a patch, first I used patch -p1 and below is the result

    โžœ  pancard_number_widget git:(master) โœ— curl https://git.drupalcode.org/project/pancard_number_widget/-/merge_requests/3.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    100  1905  100  1905    0     0   3980      0 --:--:-- --:--:-- --:--:--  40100  1905  100  1905    0     0   3977      0 --:--:-- --:--:-- --:--:--  4036
    patching file README.md
    No such line 32 in input file, ignoring
    3 out of 3 hunks failed--saving rejects to README.md.rej

    and second method is git apply -v, and please look at the result below

    โžœ  pancard_number_widget git:(master) โœ— curl https://git.drupalcode.org/project/pancard_number_widget/-/merge_requests/3.diff | git apply -v
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    100  1905  100  1905    0     0   3539      0 --:--:-- --:--:-- --:--:--  35100  1905  100  1905    0     0   3537      0 --:--:-- --:--:-- --:--:--  3587
    Skipped patch 'README.md'.
    

    hence moving this to needs work.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia mukhtarm

    Hi @clarkssquared The patch from MR is applying fine for me. Please follow this instruction to apply the patch MR: https://drupal.stackexchange.com/questions/303436/how-do-i-apply-patches...

  • Status changed to Needs review about 1 year ago
  • Status changed to RTBC 6 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia dev16.addweb

    Hello,
    I have tested MR !3 and it's working as accepted. found no errors or warnings.

Production build 0.71.5 2024