- Issue created by @vimal_nadar
- last update
over 1 year ago Composer error. Unable to continue. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:57pm 4 July 2023 - last update
over 1 year ago Composer error. Unable to continue. - Status changed to Needs work
over 1 year ago 7:03am 5 July 2023 Verified the MR44, readme.md file is added. The only I can see is the patch is not cleanly applied ->
44.patch:66: new blank line at EOF.
+
warning: 1 line adds whitespace errors.- First commit to issue fork.
- last update
over 1 year ago Composer error. Unable to continue. - Status changed to Needs review
over 1 year ago 1:03pm 12 July 2023 - ๐ฎ๐ณIndia urvashi_vora Madhya Pradesh, India
Hi @Tanuja Bohra,
I have removed the whitespace.
Please review.
Thanks
@urvashi_vora, still showing the same ->
44.patch:66: new blank line at EOF.
+
warning: 1 line adds whitespace errors.- ๐ฆ๐นAustria maxilein
Could you please add an example what the outcome of a dependency calculation might be?
- Status changed to Needs work
over 1 year ago 3:17am 5 September 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi urvashi_vora
I applied and reviewed your MR and confirmed that it adds a README.md file to the module. But it is not following the README.md template โ . Please look at the screenshot I attached for your reference
Thank you
- ๐ฎ๐ณIndia Anjali Mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- last update
over 1 year ago Composer error. Unable to continue. - Status changed to Needs review
over 1 year ago 7:28am 15 September 2023 - Status changed to Needs work
about 1 year ago 4:07am 25 September 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Anjali Mehta
I reviewed your changes and still do not follow README.md template, the "Project name and introduction" is over 80 text. Make sure the text is within around 80 cols. Please look at the screenshot I attached for your reference
Thank you
- Assigned to Priya_Degwekar
- ๐ฎ๐ณIndia Priya_Degwekar
Hi,
I have created a patch to resolve the issue #12 ๐ Add a README file Needs work .
Please review.
thanks - Status changed to Needs review
about 1 year ago 4:45am 25 September 2023 - last update
about 1 year ago Composer error. Unable to continue. - last update
about 1 year ago Composer error. Unable to continue. - last update
about 1 year ago Composer require failure - Issue was unassigned.
- Status changed to Needs work
about 1 year ago 5:40am 28 September 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi Priya_Degwekar
I applied and reviewed your patch but it doesn't resolve the issue in comment #12 and your patch has only had 4 maintainers while the module had 7 maintainers. Please look at the screenshot I attached for your reference.
Thank you
- Status changed to Needs review
about 1 year ago 2:04pm 28 September 2023 - last update
about 1 year ago Patch Failed to Apply - ๐ฎ๐ณIndia sakthi_dev
Created a patch by addressing the comment in #12 and also fixed phpcs issues there. Please review.
- Status changed to Needs work
about 1 year ago 12:22am 29 September 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi sakthi_dev
Your patch doesn't have any contents on it. Please upload a new patch. Thank you
- Assigned to yogesh_ghatode
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:28pm 29 September 2023 - last update
about 1 year ago Composer error. Unable to continue. - ๐ฎ๐ณIndia yogesh_ghatode
Hi KenyoOwen,
I have created a patch to resolve the comment no. #16. Please let me know If anything else required.
Thank You
- last update
about 1 year ago 36 pass - Status changed to Needs work
11 months ago 8:05am 18 January 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed 3372293-20.patch, there are 3 hyphens given in a line after every section.
Please review the patch once as Two lines prior to ##/### headings is required. - ๐ฎ๐ณIndia ravi kant Jaipur
ravi kant โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 10.2.1 + Environment: PHP 7.3 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Status changed to Needs review
11 months ago 10:14am 19 January 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
@Nupur Badola
Did not find any hyphens in README.md file. The hyphens may be part of patch file.
Also i have made changes and updated MR !44. - Status changed to RTBC
11 months ago 6:16am 22 January 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed MR!44, the file is updated as per the readme.md file template. Hence marking it to RTBC.
- Status changed to Needs work
11 months ago 7:54am 22 January 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi ravi kant
I reviewed your MR!44 and introduction name text should be changed from
This module provides an API for allowing modules to collaborate on digging
toThe Dependency Calculation module provides an API for allowing modules to collaborate on digging
for better readability.Thank you
- ๐ฎ๐ณIndia ravi kant Jaipur
@kenyoOwen
The introduction text is same as module page so i think we should not change it.