- Issue created by @urvashi_vora
- Status changed to Needs work
almost 2 years ago 3:14pm 3 July 2023 - 🇵ðŸ‡Philippines roberttabigue
Hi @urvashi_vora,
I got an error when applying your Patch, please see the attached screenshot for reference.
Moving this to Needs work.
Thank you.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:40am 4 July 2023 - Status changed to RTBC
almost 2 years ago 2:50pm 4 July 2023 - 🇵ðŸ‡Philippines roberttabigue
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly.
Checking patch README.md... Checking patch src/Form/MediaPhotoSwipeSettingsForm.php... Checking patch src/Plugin/Field/FieldFormatter/MediaImagePhotoSwipeFormatter.php... Applied patch README.md cleanly. Applied patch src/Form/MediaPhotoSwipeSettingsForm.php cleanly. Applied patch src/Plugin/Field/FieldFormatter/MediaImagePhotoSwipeFormatter.php cleanly.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ab_age_gate/
and all PHPCS errors have been fixed.
Successfully applied to Media PhotoSwipe module with 1.0.0-alpha1 version and with the Drupal core version of 9.5.x.
Please see the attached screenshots for your reference.
I'm moving this now to RTBC.
Thank you!
- Status changed to Needs work
almost 2 years ago 8:10pm 4 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** + * The Get EntityTypeManagerInterface. + * + * @var \Drupal\Core\Entity\EntityTypeManagerInterface + */ + protected $entityTypeManager; +
That description is not correct for a property and it does not make sense.
- First commit to issue fork.
- @frederikvho opened merge request.
- @frederikvho opened merge request.
- Status changed to Needs review
almost 2 years ago 11:00pm 4 July 2023 - 🇧🇪Belgium Frederikvho Belgium
Hi,
I created a fork from the most recent branch 1.0.x-dev, also the patch from #4 seemed to be for that branch as well.
Summary:
- Applied patch from #4
- Applied additional phpcbf fixes
- Fixed comment #7 and changed the description.
Please see: merge request !4
- Status changed to RTBC
almost 2 years ago 8:08am 5 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The MR correctly changes the files.
-
levmyshkin →
committed 4bc1d59f on 1.0.x authored by
Frederikvho →
Issue #3371971: Fix the issues reported by phpcs
-
levmyshkin →
committed 4bc1d59f on 1.0.x authored by
Frederikvho →
- Status changed to Fixed
over 1 year ago 9:59pm 29 July 2023 - Status changed to Fixed
over 1 year ago 7:30am 1 August 2023