- Issue created by @kim.pepper
- Status changed to Needs review
over 1 year ago 3:33pm 12 July 2023 - last update
over 1 year ago 49 pass - ๐ฎ๐ณIndia sidharth_soman Bangalore
Hi, I've made the required change in the 'url' property of the configForm in StandardConnector.php. Please test and review this patch.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
@sidharth_soman thanks for your patch. This will only affect the default value that is set in the form.
We want to trim the value entered by the user, before it gets saved.
- ๐จ๐ดColombia Robinson Galvez
Robinson Galvez โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @robinson-galvez opened merge request.
- ๐ฎ๐ณIndia keshavv India
keshav.k โ made their first commit to this issueโs fork.
- last update
over 1 year ago 49 pass - ๐ฎ๐ณIndia keshavv India
#2 Patch is not needed as
rtrim()
is already there in the submit handler. It will trim the URL while submitting the form.
I have created an MR and changedrtrim()
totrim()
So that it will trim the value from both sides.
Please review the MR.
Thank you. Tested the patch and it worked. I suggest another reviewer confirm since I'm still new.
- Status changed to Needs work
over 1 year ago 9:48pm 27 July 2023 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
- First commit to issue fork.
- last update
over 1 year ago 49 pass - Status changed to Needs review
over 1 year ago 2:06pm 10 August 2023 - last update
about 1 year ago 49 pass - Status changed to Fixed
about 1 year ago 10:33pm 22 August 2023 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Merged to 2.x. Thanks!
-
kim.pepper โ
committed 79fc6b15 on 2.x authored by
Robinson Galvez โ
Issue #3371727 by keshavv, sourabhjain, sidharth_soman, mariamkhalifa:...
-
kim.pepper โ
committed 79fc6b15 on 2.x authored by
Robinson Galvez โ
Automatically closed - issue fixed for 2 weeks with no activity.