- Issue created by @sonam_sharma
- Issue was unassigned.
- š®š¹Italy apaderno Brescia, š®š¹
Since the issue is showing what PHP_CodeSniffer shows, let us rescope it to fix all the warnings/errors reported by PHP_CodeSniffer.
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
- First commit to issue fork.
- Merge request !2Issue #3370016 by kalash: Fixed the issues reported by PHPCS. ā (Open) created by kalash-j
- Status changed to Needs review
7 months ago 12:18pm 22 May 2024 - š®š³India kalash-j jaipur
hello , i have solved all the issues that PHPCS has shown.
MR!2 have 0 PHPCS error please check. - Status changed to RTBC
7 months ago 1:18pm 26 May 2024 - šµšPhilippines clarkssquared
Hi
I applied the updated MR !2 and I followed the steps to reproduce and confirmed that the PHPCS issues:
ā contrib git:(master) ā phpcs --standard=Drupal --extensions=php,module,inc,install,info,txt,md multi_region FILE: ...local/web/modules/contrib/multi_region/src/Form/ConfigurableRegionForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 10 | WARNING | The class short comment should describe what the class does and | | not simply repeat the class name -------------------------------------------------------------------------------- FILE: ...ules/contrib/multi_region/src/Plugin/Block/RegionLanguageSwitcherBlock.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Access\AccessResult. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...b/modules/contrib/multi_region/src/ConfigurableRegionHtmlRouteProvider.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 19 | WARNING | Possible useless method overriding detected -------------------------------------------------------------------------------- FILE: ...odules/contrib/multi_region/src/ConfigurableRegionAccessControlHandler.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Access\AccessResult. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...cal/web/modules/contrib/multi_region/src/ConfigurableRegionListBuilder.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 7 | WARNING | [x] Unused use statement -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...rojects/d9/d9-local/web/modules/contrib/multi_region/src/RegionManager.php -------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 8 | WARNING | [x] Unused use statement 129 | ERROR | [x] Object operator not indented correctly; expected 8 spaces | | but found 10 -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 157ms; Memory: 8MB ā contrib git:(master) ā cd multi_region ā multi_region git:(master) ā curl https://git.drupalcode.org/project/multi_region/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 10218 0 10218 0 0 19688 0 --:--:-- --:--:-- --:--:-- 19918 patching file 'src/ConfigurableRegionAccessControlHandler.php' patching file 'src/ConfigurableRegionHtmlRouteProvider.php' patching file 'src/ConfigurableRegionListBuilder.php' patching file 'src/Form/ConfigurableRegionForm.php' patching file 'src/Plugin/Block/RegionLanguageSwitcherBlock.php' patching file 'src/RegionManager.php' ā multi_region git:(master) ā .. ā contrib git:(master) ā phpcs --standard=Drupal --extensions=php,module,inc,install,info,txt,md multi_region ā contrib git:(master) ā - Status changed to Needs work
7 months ago 8:51pm 26 May 2024 - Status changed to Needs review
7 months ago 6:17pm 28 May 2024 - š®š³India kalash-j jaipur
@apaderno i have done the changes on the feedback you have provided
- Status changed to RTBC
5 months ago 3:52pm 28 July 2024 - š®š³India Tirupati_Singh
Hi, I've applied the MR!2 as patch and it applied successfully with no errors. After applying patch all the mentioned phpcs errors has been resolved successfully. Hence, moving the issue status to Reviewed and tested.