Fix the issues reported by phpcs

Issues Fixed

Hi vishal365365

I applied your patch #2 to my local but I noticed that after applying the patch there are still PHPCS issues/warning shown in my terminal, I executed the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml seeds_media and below is the output of my terminal

FILE: /Users/studenttrainees/Projects/drupalorgissues/docroot/modules/contrib/seeds_media/README.md
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 110 characters
7 | WARNING | Line exceeds 80 characters; contains 130 characters
9 | WARNING | Line exceeds 80 characters; contains 81 characters
15 | WARNING | Line exceeds 80 characters; contains 114 characters
22 | WARNING | Line exceeds 80 characters; contains 114 characters
---------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Projects/drupalorgissues/docroot/modules/contrib/seeds_media/src/Form/SeedsMediaConfigForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
30 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
41 | WARNING | ImageStyle::loadMultiple calls should be avoided in classes, use dependency injection instead
50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Projects/drupalorgissues/docroot/modules/contrib/seeds_media/src/Plugin/entity_embed/EntityEmbedDisplay/MediaImage.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
50 | WARNING | Unused variable $embed_button.
52 | WARNING | Unused variable $editor.
54 | WARNING | Unused variable $entity.
55 | WARNING | Unused variable $values.
80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
99 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
---------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/studenttrainees/Projects/drupalorgissues/docroot/modules/contrib/seeds_media/src/MediaHelper.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
106 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------

Time: 403ms; Memory: 10MB

Please also look at the attached screenshots for your reference.

Thank you

bharath-kondeti → made their first commit to this issue’s fork.

Attaching a patch addressing all the issue. Please review

The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.

Issue summary updated.