- Issue created by @sonam_sharma
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 10:58am 3 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:16pm 13 July 2023 - Status changed to Needs work
over 1 year ago 1:39pm 13 July 2023 - 🇵ðŸ‡Philippines roberttabigue
Hi @sonam_sharma,
I reviewed your changes and confirmed the Patch was applied cleanly to the Curious Chronicles module against 1.0.x-dev on Drupal 9.5.10.
Checking patch curious_chronicles.theme... Applied patch curious_chronicles.theme cleanly.
However, there were still massive PHPCS errors detected.
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/css/navbar.css ------------------------------------------------------------------------------------------------------------- FOUND 179 ERRORS AFFECTING 179 LINES ------------------------------------------------------------------------------------------------------------- 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 124 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 131 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 132 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 136 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 145 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 146 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 148 | ERROR | [x] Blank lines are not allowed in class definitions 149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 151 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 153 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 154 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 155 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 156 | ERROR | [x] Blank lines are not allowed in class definitions 157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 161 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 162 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 163 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 164 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 165 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 166 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 170 | ERROR | [x] Blank lines are not allowed in class definitions 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 172 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 173 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 174 | ERROR | [x] Blank lines are not allowed in class definitions 175 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 176 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 178 | ERROR | [x] Blank lines are not allowed in class definitions 179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 180 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 181 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 182 | ERROR | [x] Blank lines are not allowed in class definitions 183 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 184 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 185 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 187 | ERROR | [x] Blank lines are not allowed in class definitions 188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 189 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 191 | ERROR | [x] Blank lines are not allowed in class definitions 192 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 200 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 201 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 203 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 204 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 208 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 210 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 219 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 221 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 222 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 223 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 224 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 225 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 226 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 227 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 231 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 238 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 239 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 241 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 245 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 246 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 247 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 248 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 249 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 250 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 251 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 255 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 256 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 257 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 258 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 259 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 263 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 264 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 265 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 266 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 267 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 268 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 269 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 270 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 271 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 272 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 179 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/css/banner.css ------------------------------------------------------------------------------------------------------------- FOUND 78 ERRORS AFFECTING 78 LINES ------------------------------------------------------------------------------------------------------------- 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 10 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 11 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 12 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Blank lines are not allowed in class definitions 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 44 | ERROR | [ ] More than 2 empty lines are not allowed 45 | ERROR | [ ] More than 2 empty lines are not allowed 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [ ] More than 2 empty lines are not allowed 111 | ERROR | [ ] More than 2 empty lines are not allowed 112 | ERROR | [ ] More than 2 empty lines are not allowed 113 | ERROR | [ ] More than 2 empty lines are not allowed 114 | ERROR | [x] Whitespace found at end of line 182 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 72 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/css/content_full.css ------------------------------------------------------------------------------------------------------------------- FOUND 145 ERRORS AFFECTING 141 LINES ------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Opening brace should be the last content on the line 1 | ERROR | [ ] Class definition is empty 1 | ERROR | [x] Closing brace of class definition must be on new line 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 52 | ERROR | [x] Whitespace found at end of line 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 127 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 146 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 154 | ERROR | [x] Opening brace should be the last content on the line 154 | ERROR | [ ] Class definition is empty 154 | ERROR | [x] Closing brace of class definition must be on new line 157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 160 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 168 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 170 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 175 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 188 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 189 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 190 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 191 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 192 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 193 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 195 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 196 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 197 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 198 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 200 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 201 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 205 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 206 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 207 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 210 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 211 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 212 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 215 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 216 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 218 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 219 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 228 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 229 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 233 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 234 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 235 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 236 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 237 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 238 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 242 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 243 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 244 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 248 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 249 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 250 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 251 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 252 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 253 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 254 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 143 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/css/content_one.css ------------------------------------------------------------------------------------------------------------------ FOUND 77 ERRORS AFFECTING 77 LINES ------------------------------------------------------------------------------------------------------------------ 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [ ] More than 2 empty lines are not allowed 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 99 | ERROR | [ ] More than 2 empty lines are not allowed 101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 125 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 127 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 137 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 75 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------ FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/js/navbar.js ----------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------- 3 | ERROR | [x] Whitespace found at end of line 7 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 13 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 23 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines 31 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/curious_chronicles.libraries.yml ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 14 | ERROR | [x] Expected 1 newline at end of file; 3 found ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/curious_chronicles.theme ----------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] There must be no blank lines after the function comment 19 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters 57 | ERROR | [x] There must be no blank lines after the function comment 85 | ERROR | [x] Expected 1 blank line after function; 0 found 88 | ERROR | [x] There must be no blank lines after the function comment ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- Time: 227ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js curious_chronicles/
Moving this to Needs work for now.
Thank you! - Status changed to Needs review
over 1 year ago 6:32am 14 July 2023 - 🇮🇳India Ashutosh Ahirwal India
Providing a fresh complete patch with fixes.
please review. - Status changed to RTBC
over 1 year ago 5:28pm 18 July 2023 - 🇵ðŸ‡Philippines roberttabigue
Hi,
I reviewed the changes and confirmed that Patch #8 was applied cleanly
Checking patch css/banner.css... Checking patch css/content_full.css... Checking patch css/content_one.css... Checking patch css/navbar.css... Checking patch curious_chronicles.libraries.yml... Checking patch curious_chronicles.theme... Checking patch js/navbar.js... Applied patch css/banner.css cleanly. Applied patch css/content_full.css cleanly. Applied patch css/content_one.css cleanly. Applied patch css/navbar.css cleanly. Applied patch curious_chronicles.libraries.yml cleanly. Applied patch curious_chronicles.theme cleanly. Applied patch js/navbar.js cleanly.
And all PHPCS errors have been fixed.
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you! - Status changed to Needs work
over 1 year ago 8:56am 19 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+/** + * @file + * Theme file to implements hooks. + */
The description for a .theme file is Functions to support theming in the [theme name] theme. where [theme name] is the name reported in the .info.yml file.
+function curious_chronicles_preprocess_page(&$variables) { + + // Allow the Attribute Class to deal with adding a css class to this element.
There is no need to put an empty line before the first code line.
+ // Get subheading. + $subheading = theme_get_setting('subheading');
That comment is not necessary, since it just describes what is already clear from the code.
+/** + * @file + * Theme settings in this file. + */
Only a
@file
tag is used per file. In the curious_chronicles.theme file, it has been already added.+/** + * Implements hook_preprocess_HOOK() for node.html.twig. + */ +function curious_chronicles_preprocess_node(&$variables) { - function curious_chronicles_preprocess_node(&$variables) { - if ($variables['node'] && $variables['node']->getType() == 'article') {
There is no need to leave empty lines before the first code line in a function.
$(document).ready(function () { - // open and close nav + // open and close nav $('#navbar-toggle').click(function () { $('.nav ul').slideToggle(); });
The indentation is not correct.
Since that comment is changed, the first word must be capitalized and the period added to the end. Truly, that comment is not necessary, since it describes something that is already clear from the code. - First commit to issue fork.
- @frederikvho opened merge request.
- Status changed to Needs review
over 1 year ago 10:44am 19 July 2023 - 🇧🇪Belgium Frederikvho Belgium
Hi,
I created a fork and a merge request for ease of use.
Summary:- Applied path from comment #8
- Fixed one remaining phpcs remark regarding a whiteline
- Fixed remarks from Apadarno's comment #11
I would like to add a remark that the comments in the 'curious_chronicles_preprocess_page' hook seem to be adding noise for me. Shouldn't they go in a README.md instead?
Please review the opened merge request.
Kind regards,
Frederik - 🇮🇹Italy apaderno Brescia, 🇮🇹
Honestly, I find some of the default values used in
curious_chronicles_preprocess_page()
like$variables['subheading'] = 'A personal Blog';
or$variables['blogheading'] = 'Blog Heading';
rather too specific. Why would every page on a site showblog
in a header or sub-header? - 🇮🇹Italy apaderno Brescia, 🇮🇹
As for the two
curious_chronicles_preprocess_page()
functions, that is not reported by PHP_CodeSniffer. It should be fixed in a different issue because that is not a coding standards issue, but a bug. - Status changed to Needs work
over 1 year ago 4:45pm 19 July 2023