- Issue created by @dieterholvoet
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - @dieterholvoet opened merge request.
- last update
over 1 year ago 29,436 pass, 6 fail - Status changed to Needs work
over 1 year ago 9:06am 13 June 2023 - 🇧🇪Belgium dieterholvoet Brussels
I added a possible fix. Only tested
OptionsButtonsWidget
though, probably needs testing with other field types extendingOptionsWidgetBase
. Also needs tests. - Status changed to Needs review
over 1 year ago 7:44am 23 June 2023 - last update
over 1 year ago 29,543 pass, 2 fail - last update
over 1 year ago 29,551 pass - 🇮🇳India ranjith_kumar_k_u Kerala
Added one more condition to the existing fix(
$field_type === 'boolean'
) and also added tests, please review The last submitted patch, 4: 3366390-4-tests-only.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 1:36pm 23 June 2023 - 🇺🇸United States smustgrave
Issue was started as an MR pointing at the correct branch and should be continued there.
- last update
over 1 year ago 29,554 pass - Status changed to Needs review
over 1 year ago 3:12pm 26 June 2023 - Status changed to RTBC
over 1 year ago 1:34pm 29 June 2023 - 🇺🇸United States smustgrave
Confirmed the issue described in the issue summary.
MR does resolve the issue - last update
over 1 year ago 29,567 pass - last update
over 1 year ago 29,571 pass - last update
over 1 year ago 29,801 pass - last update
over 1 year ago 29,773 pass, 1 fail - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,807 pass - last update
over 1 year ago 29,812 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,815 pass - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,873 pass - last update
over 1 year ago 29,877 pass - last update
over 1 year ago 29,879 pass - last update
over 1 year ago 29,886 pass - last update
over 1 year ago 29,908 pass - last update
over 1 year ago 29,899 pass, 3 fail - last update
over 1 year ago 29,946 pass 51:47 48:17 Running- last update
over 1 year ago 29,953 pass - last update
over 1 year ago 29,958 pass - Status changed to Needs work
over 1 year ago 12:23am 10 August 2023 - 🇳🇿New Zealand quietone
@DieterHolvoet, thanks! it would be nice to having this working as expected.
The IS is clear and there is a proposed resolution. Thanks.
Reading the comments there is an unanswered question in #3. Thank needs to be done.
With that question in mind I applied the change and tested. This works fine for boolean fields. I then tested with an integer list field and the problem still existed. I think a general solution for all fields using the 'Check boxes/radio buttons/' display is needed.
And then I looked at the code and this is just applying the fix to booleans,
if ($field_type === 'boolean' &&
.Setting back to needs work.