Empty option is not selected if field is empty, using the radio buttons widget

Issue created by @DieterHolvoet
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
Not currently mergeable.
@dieterholvoet opened merge request.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
29,436 pass, 6 fail
Status changed to Needs work about 1 year ago9:06am 13 June 2023
Comment about 1 year ago →
🇧🇪Belgium DieterHolvoet Brussels
I added a possible fix. Only tested OptionsButtonsWidget though, probably needs testing with other field types extending OptionsWidgetBase. Also needs tests.
Status changed to Needs review 12 months ago7:44am 23 June 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,543 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,551 pass
Comment 12 months ago →
🇮🇳India ranjith_kumar_k_u Kerala
Added one more condition to the existing fix($field_type === 'boolean') and also added tests, please review
Comment 12 months ago →
System Message
The last submitted patch, 4: 3366390-4-tests-only.patch, failed testing. View results →
Status changed to Needs work 12 months ago1:36pm 23 June 2023
Comment 12 months ago →
🇺🇸United States smustgrave
Issue was started as an MR pointing at the correct branch and should be continued there.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,554 pass
Status changed to Needs review 12 months ago3:12pm 26 June 2023
Comment 12 months ago →
🇮🇳India ranjith_kumar_k_u Kerala
Status changed to RTBC 12 months ago1:34pm 29 June 2023
Comment 12 months ago →
🇺🇸United States smustgrave
Confirmed the issue described in the issue summary.
MR does resolve the issue
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,567 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,571 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,801 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,773 pass, 1 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 12 months ago
29,802 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,802 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,807 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,812 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,815 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,815 pass
Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
Waiting for branch to pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,873 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,877 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,879 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,886 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,908 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,899 pass, 3 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,946 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
23:04
19:34
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 11 months ago
29,953 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
29,958 pass
Status changed to Needs work 10 months ago12:23am 10 August 2023
Comment 10 months ago →
🇳🇿New Zealand quietone New Zealand
@DieterHolvoet, thanks! it would be nice to having this working as expected.

The IS is clear and there is a proposed resolution. Thanks.

Reading the comments there is an unanswered question in #3. Thank needs to be done.

With that question in mind I applied the change and tested. This works fine for boolean fields. I then tested with an integer list field and the problem still existed. I think a general solution for all fields using the 'Check boxes/radio buttons/' display is needed.

And then I looked at the code and this is just applying the fix to booleans, if ($field_type === 'boolean' &&.

Setting back to needs work.

Empty option is not selected if field is empty, using the radio buttons widget

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments & Activities