- Issue created by @amanire
- last update
over 1 year ago Build Successful - @amanire opened merge request.
- Status changed to Needs review
over 1 year ago 4:51pm 9 June 2023 - Status changed to Needs work
over 1 year ago 9:23pm 9 June 2023 - 🇺🇸United States smustgrave
Great to see these start to come through.
But this caused some nightwatch failures https://dispatcher.drupalci.org/job/drupal_patches/186046/console
- 🇺🇸United States amanire
#block-umami-branding is missing? That's very odd, since I had started working on that component first but didn't think I had committed anything and the merge request diff only shows work on the disclaimer. I'll take a closer look when I can find time.
- First commit to issue fork.
- last update
over 1 year ago Build Successful - Status changed to Needs review
over 1 year ago 3:50am 13 June 2023 - 🇮🇳India gauravvvv Delhi, India
Removed disclaimer.css file from libraries and added description in schema file.
- Status changed to Needs work
over 1 year ago 1:31pm 13 June 2023 - last update
over 1 year ago Build Successful - last update
over 1 year ago 29,430 pass - last update
over 1 year ago Build Successful - @amanire opened merge request.
- last update
over 1 year ago 29,430 pass - Status changed to Needs review
over 1 year ago 3:05pm 16 June 2023 - 🇺🇸United States amanire
This passed testing after enabling the SDC module.
- Status changed to RTBC
over 1 year ago 4:09pm 17 June 2023 - 🇺🇸United States smustgrave
Applied the MR and did a fresh install of umami profile.
Verified the disclaimer appeared at the bottom with the same styling as before. - last update
over 1 year ago 29,431 pass - last update
over 1 year ago 29,431 pass - last update
over 1 year ago 29,437 pass - last update
over 1 year ago 29,437 pass - last update
over 1 year ago 29,437 pass 16:57 10:33 Running- last update
over 1 year ago 29,445 pass - last update
over 1 year ago 29,444 pass - Status changed to Needs review
over 1 year ago 3:02pm 3 July 2023 - 🇺🇸United States amanire
@lauriii I assume you mean in in
disclaimer.component.yml
? Happy to do that if you can confirm. - 🇫🇮Finland lauriii Finland
@amanire Yes, that's the file I thought we should edit 👍
- last update
over 1 year ago 29,444 pass - last update
over 1 year ago 29,444 pass - Status changed to RTBC
over 1 year ago 10:33pm 9 July 2023 - last update
over 1 year ago 29,440 pass - Status changed to Fixed
over 1 year ago 8:36pm 11 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.