Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 7 June 2023, over 1 year ago
Updated 11 July 2024, 4 months ago
📌 Task
Status

Needs review

Version

4.0

Component

Code

Created by

🇮🇳India arti_parmar

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @arti_parmar
  • Comment over 1 year ago →
    🇮🇳India arti_parmar
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India arti_parmar

    Kindly review patch.

  • First commit to issue fork.
  • @kpoornima opened merge request.
  • Merge request !73365312-phpcs fixing → (Open) created by kpoornima
  • Comment over 1 year ago →
    🇮🇳India kpoornima

    Please Merge MR7 covered all files phpcs errors and warnings

  • Comment over 1 year ago →
    🇮🇳India heykarthikwithu Bengaluru 🌍
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    Since the issue summary does not describe in sufficient details the changes to do, this is not a novice issue.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Comment about 1 year ago →
    bindu r

    bindu r → made their first commit to this issue’s fork.

  • Comment about 1 year ago →
    🇷🇺Russia zniki.ru
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇷🇺Russia zniki.ru

    Update MR 7.

  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    a.aaronjake

    Hi @Nikolay Shapovalov,

    Applied MR !7's changes successfully but still threw multiple errors/warnings. Please see below.

    thunder_admin git:(8.x-3.x) curl https://git.drupalcode.org/project/thunder_admin/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  416k    0  416k    0     0   161k      0 --:--:--  0:00:02 --:--:--  162k
patching file css/backend.css
patching file css/base/elements.css
patching file css/base/print.css
patching file css/base/typography.css
patching file css/color-scheme-inverted.css
patching file css/components/admin-list.css
patching file css/components/admin-search-api.css
patching file css/components/admin.toolbar.css
patching file css/components/admin_toolbar_tools.toolbar.icon.css
patching file css/components/breadcrumb.css
patching file css/components/buttons.css
patching file css/components/container-inline.css
patching file css/components/container-inline.module.css
patching file css/components/content-header.css
patching file css/components/details.css
patching file css/components/dialog.css
patching file css/components/dropbutton.component.css
patching file css/components/dropzonejs.widget.css
patching file css/components/entity-meta.css
patching file css/components/entity_browser.tabs.css
patching file css/components/field-ui.css
patching file css/components/form-element.css
patching file css/components/form.css
patching file css/components/help.css
patching file css/components/jquery.ui/theme.css
patching file css/components/media-form.css
patching file css/components/media.css
patching file css/components/media_entity_browser.view.css
patching file css/components/menus-and-lists.css
patching file css/components/messages.css
patching file css/components/modules-page.css
patching file css/components/node.css
patching file css/components/page-title.css
patching file css/components/pager.css
patching file css/components/panel.css
patching file css/components/quickedit.css
patching file css/components/search-admin-settings.css
patching file css/components/select2/layout.css
patching file css/components/skip-link.css
patching file css/components/system-status-counter.css
patching file css/components/system-status-report-counters.css
patching file css/components/system-status-report-general-info.css
patching file css/components/system-status-report.css
patching file css/components/tabledrag.css
patching file css/components/tables.css
patching file css/components/tablesort-indicator.css
patching file css/components/tabs.css
patching file css/components/toolbar.icons.theme.css
patching file css/components/toolbar.menu.css
patching file css/components/toolbar.module.css
patching file css/components/toolbar.theme.css
patching file css/components/tour.theme.css
patching file css/components/user.css
patching file css/components/vertical-tabs.css
patching file css/components/views-ui.css
patching file css/content-form-layout.css
patching file css/content-form-theme.css
patching file css/layout/layout.css
patching file css/paragraphs-sorting.css
patching file css/paragraphs-widget--deprecated.css
patching file css/paragraphs-widget.css
patching file css/theme/ckeditor-dialog.css
patching file css/theme/colors.css
patching file css/theme/install-page.css
patching file css/theme/maintenance-page.css
patching file templates/field/field--field-media-images--paragraph-preview.html.twig
patching file templates/form/datetime-wrapper.html.twig
patching file thunder_admin.theme
➜  thunder_admin git:(8.x-3.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig thunder_admin

FILE: ...PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/thunder_admin/README.md
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 30 WARNINGS AFFECTING 30 LINES
-----------------------------------------------------------------------------------------
   9 | WARNING | Line exceeds 80 characters; contains 110 characters
  10 | WARNING | Line exceeds 80 characters; contains 119 characters
  13 | WARNING | Line exceeds 80 characters; contains 119 characters
  14 | WARNING | Line exceeds 80 characters; contains 119 characters
  19 | WARNING | Line exceeds 80 characters; contains 117 characters
  20 | WARNING | Line exceeds 80 characters; contains 116 characters
  21 | WARNING | Line exceeds 80 characters; contains 100 characters
  22 | WARNING | Line exceeds 80 characters; contains 115 characters
  26 | WARNING | Line exceeds 80 characters; contains 119 characters
  35 | WARNING | Line exceeds 80 characters; contains 127 characters
  36 | WARNING | Line exceeds 80 characters; contains 90 characters
  38 | WARNING | Line exceeds 80 characters; contains 93 characters
  41 | WARNING | Line exceeds 80 characters; contains 123 characters
  45 | WARNING | Line exceeds 80 characters; contains 118 characters
  46 | WARNING | Line exceeds 80 characters; contains 160 characters
  47 | WARNING | Line exceeds 80 characters; contains 192 characters
  71 | WARNING | Line exceeds 80 characters; contains 155 characters
  74 | WARNING | Line exceeds 80 characters; contains 82 characters
  78 | WARNING | Line exceeds 80 characters; contains 126 characters
  80 | WARNING | Line exceeds 80 characters; contains 112 characters
  82 | WARNING | Line exceeds 80 characters; contains 100 characters
  88 | WARNING | Line exceeds 80 characters; contains 158 characters
  89 | WARNING | Line exceeds 80 characters; contains 160 characters
  93 | WARNING | Line exceeds 80 characters; contains 177 characters
  94 | WARNING | Line exceeds 80 characters; contains 179 characters
  96 | WARNING | Line exceeds 80 characters; contains 119 characters
 100 | WARNING | Line exceeds 80 characters; contains 143 characters
 102 | WARNING | Line exceeds 80 characters; contains 113 characters
 104 | WARNING | Line exceeds 80 characters; contains 118 characters
 106 | WARNING | Line exceeds 80 characters; contains 113 characters
-----------------------------------------------------------------------------------------


FILE: ...rns/Demo-site/drupal-orgissue/web/modules/contrib/thunder_admin/templates/README.md
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------
  8 | WARNING | Line exceeds 80 characters; contains 88 characters
  9 | WARNING | Line exceeds 80 characters; contains 101 characters
 10 | WARNING | Line exceeds 80 characters; contains 99 characters
 12 | WARNING | Line exceeds 80 characters; contains 86 characters
 14 | WARNING | Line exceeds 80 characters; contains 84 characters
 19 | WARNING | Line exceeds 80 characters; contains 84 characters
-----------------------------------------------------------------------------------------


FILE: ...rns/Demo-site/drupal-orgissue/web/modules/contrib/thunder_admin/thunder_admin.theme
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
  10 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one
     |         |     is Drupal\Core\Entity\ContentEntityBase.
 418 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------


FILE: ...tInterns/Demo-site/drupal-orgissue/web/modules/contrib/thunder_admin/sass/README.md
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------
  2 | WARNING | Line exceeds 80 characters; contains 121 characters
  4 | WARNING | Line exceeds 80 characters; contains 97 characters
 17 | WARNING | Line exceeds 80 characters; contains 88 characters
 21 | WARNING | Line exceeds 80 characters; contains 86 characters
 22 | WARNING | Line exceeds 80 characters; contains 88 characters
-----------------------------------------------------------------------------------------

Time: 1.21 secs; Memory: 18MB

    Kindly check

    Thanks,
    Jake

  • Comment 6 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    apaderno → changed the visibility of the branch 3365312-fix-the-issues to hidden.

  • Pipeline finished with Success
    6 months ago
    Total: 160s
    #192750
  • Comment 6 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Pipeline finished with Success
    6 months ago
    Total: 147s
    #192769
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    a.aaronjake

    Hi @apaderno,

    Applied your changes on MR !7, I still get multiple issues.

    thunder_admin git:(8.x-3.x) curl https://git.drupalcode.org/project/thunder_admin/-/merge_requests/7.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  418k    0  418k    0     0   394k      0 --:--:--  0:00:01 --:--:--  399k
patching file .gitlab-ci.yml
patching file css/backend.css
patching file css/base/elements.css
patching file css/base/print.css
patching file css/base/typography.css
patching file css/color-scheme-inverted.css
patching file css/components/admin-list.css
patching file css/components/admin-search-api.css
patching file css/components/admin.toolbar.css
patching file css/components/admin_toolbar_tools.toolbar.icon.css
patching file css/components/breadcrumb.css
patching file css/components/buttons.css
patching file css/components/container-inline.css
patching file css/components/container-inline.module.css
patching file css/components/content-header.css
patching file css/components/details.css
patching file css/components/dialog.css
patching file css/components/dropbutton.component.css
patching file css/components/dropzonejs.widget.css
patching file css/components/entity-meta.css
patching file css/components/entity_browser.tabs.css
patching file css/components/field-ui.css
patching file css/components/form-element.css
patching file css/components/form.css
patching file css/components/help.css
patching file css/components/jquery.ui/theme.css
patching file css/components/media-form.css
patching file css/components/media.css
patching file css/components/media_entity_browser.view.css
patching file css/components/menus-and-lists.css
patching file css/components/messages.css
patching file css/components/modules-page.css
patching file css/components/node.css
patching file css/components/page-title.css
patching file css/components/pager.css
patching file css/components/panel.css
patching file css/components/quickedit.css
patching file css/components/search-admin-settings.css
patching file css/components/select2/layout.css
patching file css/components/skip-link.css
patching file css/components/system-status-counter.css
patching file css/components/system-status-report-counters.css
patching file css/components/system-status-report-general-info.css
patching file css/components/system-status-report.css
patching file css/components/tabledrag.css
patching file css/components/tables.css
patching file css/components/tablesort-indicator.css
patching file css/components/tabs.css
patching file css/components/toolbar.icons.theme.css
patching file css/components/toolbar.menu.css
patching file css/components/toolbar.module.css
patching file css/components/toolbar.theme.css
patching file css/components/tour.theme.css
patching file css/components/user.css
patching file css/components/vertical-tabs.css
patching file css/components/views-ui.css
patching file css/content-form-layout.css
patching file css/content-form-theme.css
patching file css/layout/layout.css
patching file css/paragraphs-sorting.css
patching file css/paragraphs-widget--deprecated.css
patching file css/paragraphs-widget.css
patching file css/theme/ckeditor-dialog.css
patching file css/theme/colors.css
patching file css/theme/install-page.css
patching file css/theme/maintenance-page.css
patching file templates/field/field--field-media-images--paragraph-preview.html.twig
patching file templates/form/datetime-wrapper.html.twig
patching file thunder_admin.theme
➜  thunder_admin git:(8.x-3.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig thunder_admin

FILE: ...erns/Demo-site/drupal-orgissue/web/modules/contrib/thunder_admin/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 30 WARNINGS AFFECTING 30 LINES
--------------------------------------------------------------------------------
   9 | WARNING | Line exceeds 80 characters; contains 110 characters
  10 | WARNING | Line exceeds 80 characters; contains 119 characters
  13 | WARNING | Line exceeds 80 characters; contains 119 characters
  14 | WARNING | Line exceeds 80 characters; contains 119 characters
  19 | WARNING | Line exceeds 80 characters; contains 117 characters
  20 | WARNING | Line exceeds 80 characters; contains 116 characters
  21 | WARNING | Line exceeds 80 characters; contains 100 characters
  22 | WARNING | Line exceeds 80 characters; contains 115 characters
  26 | WARNING | Line exceeds 80 characters; contains 119 characters
  35 | WARNING | Line exceeds 80 characters; contains 127 characters
  36 | WARNING | Line exceeds 80 characters; contains 90 characters
  38 | WARNING | Line exceeds 80 characters; contains 93 characters
  41 | WARNING | Line exceeds 80 characters; contains 123 characters
  45 | WARNING | Line exceeds 80 characters; contains 118 characters
  46 | WARNING | Line exceeds 80 characters; contains 160 characters
  47 | WARNING | Line exceeds 80 characters; contains 192 characters
  71 | WARNING | Line exceeds 80 characters; contains 155 characters
  74 | WARNING | Line exceeds 80 characters; contains 82 characters
  78 | WARNING | Line exceeds 80 characters; contains 126 characters
  80 | WARNING | Line exceeds 80 characters; contains 112 characters
  82 | WARNING | Line exceeds 80 characters; contains 100 characters
  88 | WARNING | Line exceeds 80 characters; contains 158 characters
  89 | WARNING | Line exceeds 80 characters; contains 160 characters
  93 | WARNING | Line exceeds 80 characters; contains 177 characters
  94 | WARNING | Line exceeds 80 characters; contains 179 characters
  96 | WARNING | Line exceeds 80 characters; contains 119 characters
 100 | WARNING | Line exceeds 80 characters; contains 143 characters
 102 | WARNING | Line exceeds 80 characters; contains 113 characters
 104 | WARNING | Line exceeds 80 characters; contains 118 characters
 106 | WARNING | Line exceeds 80 characters; contains 113 characters
--------------------------------------------------------------------------------


FILE: ...site/drupal-orgissue/web/modules/contrib/thunder_admin/templates/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
  8 | WARNING | Line exceeds 80 characters; contains 88 characters
  9 | WARNING | Line exceeds 80 characters; contains 101 characters
 10 | WARNING | Line exceeds 80 characters; contains 99 characters
 12 | WARNING | Line exceeds 80 characters; contains 86 characters
 14 | WARNING | Line exceeds 80 characters; contains 84 characters
 19 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------------


FILE: ...Demo-site/drupal-orgissue/web/modules/contrib/thunder_admin/sass/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  2 | WARNING | Line exceeds 80 characters; contains 121 characters
  4 | WARNING | Line exceeds 80 characters; contains 97 characters
 17 | WARNING | Line exceeds 80 characters; contains 88 characters
 21 | WARNING | Line exceeds 80 characters; contains 86 characters
 22 | WARNING | Line exceeds 80 characters; contains 88 characters
--------------------------------------------------------------------------------

Time: 1.52 secs; Memory: 18MB

    Thanks,
    Jake

  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • Merge request !17Issue #3365312: Fix the issues reported by phpcs → (Open) created by apaderno
  • Pipeline finished with Success
    4 months ago
    Total: 147s
    #221659
  • Comment 4 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024