- Issue created by @catch
- First commit to issue fork.
- last update
over 1 year ago 29,505 pass - @lendude opened merge request.
- Status changed to Needs review
over 1 year ago 1:58pm 21 June 2023 - π³π±Netherlands Lendude Amsterdam
This turns the two Multiple values settings, that we assume to be numbers, into numbers fields.
Tested this:
these will eventually get fixed once they're resaved from the UI and the validation error kicks in
Turns out this isn't what happens if you just make these number fields. If you start with a string value and then apply this fix and reload the View it will show an empty value. So no validation error is given if we solve it like this.
We could validate this with actual form validation rules and in that case it would throw the error. But that feels a little overkill to me, also since we already hardend the ode against people sneaking in stringsOpinions welcome!
- Status changed to Needs work
over 1 year ago 4:07pm 21 June 2023 - πΊπΈUnited States smustgrave
I agree that it makes sense change to a number form.
Maybe a follow up could be open to add an "all" option
Form could maybe be
All - new
Custom - current setup of using Display N value(s)Question though will an update hook be needed to transform current values from string to int or is the form API smart enough to know that.