Fix the issues reported by phpcs

Created a patch to fix the issues reported by phpcs.

Please review.
Thank You.

Hello everyone,
Tested the #2 patch for pachu 1.0.x-dev on Drupal 9.5.9 and PHP 8.2.4, the issue has been successfully fixed for me. Attached before and after screenshots for references.

Thank you for your support!!!

The reported errors/warnings are more than the ones shown in the issue summary.

True @apaderno . Updated patch.

Only warning left:

That warning just says phpcs cannot show errors/warnings for minified files. It does not require any change in the project files.

+;/*!
  * jQuery Cycle Plugin (with Transition Definitions)
  * Examples and documentation at: http://jquery.malsup.com/cycle/
  * Copyright (c) 2007-2013 M. Alsup
@@ -6,26 +6,26 @@
  * Dual licensed under the MIT and GPL licenses.
  * http://jquery.malsup.com/license.html
  * Requires: jQuery v1.7.1 or later
- */
-;(function($, undefined) {
+ */(function ($, undefined) {

It is not necessary to move the semicolon before the comment; it needs to be simple be removed.
A closure is placed on its own line, not on the line containing a comment delimiter.

function debug(s) {
-	if ($.fn.cycle.debug)
-		log(s);
-}		
+    if ($.fn.cycle.debug) {
+        log(s);
+    }
+}

Those lines are still not correctly indented, since Drupal uses two spaces also for the indentation of JavaScript files.

+    /*global console */
+    if (window.console && console.log) {
+        console.log('[cycle] ' + Array.prototype.join.call(arguments,' '));
+    }

I would rather remove that comment (which is still not correctly formatted), since there is no need to explain what window.console is accessing.

I would also avoid changing the jquery.cycle.all.js file, since that is a file copied from another repository. It does not make sense to change that file all the time it is updated. (The fact projects hosted on drupal.org should avoid including files hosted somewhere else is a different matter, considering there are exceptions to that.)
The same holds true for other files that have been copied from other repositories.

Addressed #9.

Hello nitin_lama
Tested your #11 patch and implemented on my website having Drupal 9.5.9 and PHP 8.2. I will be adding screenshot (after patch) for reference.
Thank you for your support!!

Ridhima gupta → made their first commit to this issue’s fork.