Fix the issues reported by phpcs

Hi urvashi_vora

I applied your patch coding-standard-issue.patch → to my local and confirmed that all the phpcs errors were fixed, however when I ran the phpcs command it shows me a warning below

FILE: /Users/studenttrainees/Drupal/drupalissues/docroot/modules/contrib/adc_block/adc_block.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Time: 844ms; Memory: 18MB

Moving this to needs work to review if this needs to be fixed or to leave as is.

Please look at the screenshot attached for your reference.

Thank you

Patch added please review.

+(function ($, Drupal, drupalSettings) {
+    Drupal.behaviors.analog_behavior = {
+        attach: function (context, settings) {
+            (function ($) {
+                function core(id, preset, options) {
+                    var adc_blockcanvas = $(id)[0];
+                    var ctx = adc_blockcanvas.getContext('2d');
+                    var adc_blockbound = adc_blockcanvas.height;
+                    var adc_blocksafepad = 0;
+                    if (preset.hasShadow) {
+                        adc_blocksafepad = 4;
+                    }
+                    var adc_blockradius = adc_blockcanvas.height / 2 - adc_blocksafepad;
+                    var adc_blocksecondStep = 2 * Math.PI / 60;
+                    var adc_blockhourStep = 2 * Math.PI / 12;
+                    var adc_blockinitialize = function () {
+                        $(adc_blockcanvas).css('max-width', '100%');
+                        $(adc_blockcanvas).css('width', $(adc_blockcanvas).css('height'));
+                        adc_blockcanvas.width = adc_blockcanvas.height;
+                        if (preset.hasShadow) {
+                            ctx.shadowOffsetX = 0.0;
+                            ctx.shadowOffsetY = 0.0;
+                            ctx.shadowBlur = preset.shadowBlur;
+                            ctx.shadowColor = preset.shadowColor;
+                        }
+                        draw();
+                    };
+                    var adc_blockp2v = function (value) {
+                        return value / 100.0 * adc_blockradius;
+                    };
+                    var adc_blockdrawMajorLines = function () {
+                        ctx.lineWidth = adc_blockp2v(preset.majorTicksLength);
+                        ctx.strokeStyle = preset.majorTicksColor;
+                        for (var i = 1; i <= 12; i++) {

The indentation must be two spaces also for JavaScript code.

+  /**
+   * {@inheritdoc}
+   *
+   * Disable block cache to keep it the Analog Clock update.
+   */

The description is not grammatically correct. It should be Disable the block cache to keep the Analog Clock block updated. It should not be necessary, since that is the reason to return 0 from getCacheMaxAge().

Addressed #4.2. Also, there were some phpcs erros in the README.md file. Updated the changes. Providing updated patch.

bharath-kondeti → made their first commit to this issue’s fork.

Addressed 4.1 after the latest patch in #6. Please review the MR https://git.drupalcode.org/project/adc_block/-/merge_requests/2

I have updated the forked repository and executed the code sniffer. Here are some warnings that need to be addressed.

FILE: ...var/www/html/web/modules/custom/adc/src/Plugin/Block/DigitalClockBlock.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
  50 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  53 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 221 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 230 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 230 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
--------------------------------------------------------------------------------

Time: 174ms; Memory: 12MB

I have added a patch to fix the warnings as per #14. Please review. Thank You.

Patch #16 applies successfully. No remaining phpcs issue left.

MR created. Please review. Thanks.

After applying patch #16 cleanly, Digital Clock block is unable to place.

Please review patch.

@chaitanyadessai instead of new MR. Its better to work on the opened MR. I've pushed changes to MR3.

nitin_lama → changed the visibility of the branch adc_block-3363471-26 to hidden.

On running the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css adc_block/, found these warnings remaining:

FILE: /home/yashaswi/contribs/adc_block/src/Plugin/Block/DigitalClockBlock.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------
  50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  53 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 221 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 230 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 230 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------