Contrib.social

Remove service location anti-patterns in constructors: system module

Open on Drupal.org →
Created on 26 May 2023, about 1 year ago
Updated 29 May 2023, about 1 year ago

@mglaman pointed out the possible problem of these three patterns in the class constructor in his blog:
$this->request = $request_stack->getCurrentRequest();
$this->nodeStorage = $entity_type_manager->getStorage('node');
$this->config = $config_factory->get('mymodule.settings');

The following classes are affected:
Drupal\system\PathBasedBreadcrumbBuilder
Drupal\system\EventSubscriber\SecurityFileUploadEventSubscriber
Drupal\system\SecurityAdvisories\SecurityAdvisoriesFetcher

📌 Task
Status

Needs work

Version

11.0 🔥

Component
System  →

Last updated 1 day ago

No maintainer
Created by

🇩🇪Germany sleitner

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024