Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org ā†’
Created on 20 May 2023, over 1 year ago
Updated 21 August 2024, 4 months ago
šŸ“Œ Task
Status

RTBC

Version

1.0

Component

Code

Created by

šŸ‡ŖšŸ‡øSpain manuel.adan šŸŒŒ

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @manuel.adan
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡ŖšŸ‡øSpain manuel.adan šŸŒŒ
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    16 pass
  • First commit to issue fork.
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India dineshkumarbollu

    Hi manuel.adan

    I review The patch #2 applied cleanly, found 1 minor issues

    vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/fixed_block_content-3361644/

    FILE: /var/www/html/vbd9/web/modules/contrib/fixed_block_content-3361644/tests/modules/fixed_block_content_test/fixed_block_content_test.info.yml
    -------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------------
    1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
    -------------------------------------------------------------------------------------------------------------------------------------------------

    Time: 2.11 secs; Memory: 12MB

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Comment 4 months ago ā†’
    a.aaronjake

    Hi @manuel.adan & @dineshkumarbollu,

    I applied the patch that was provided, it was applied not-so successfully and may be the reason multiple errors were reported. Please see below:

    fixed_block_content git:(8.x-1.x) āœ— curl https://www.drupal.org/files/issues/2023-05-20/fixed_block_content-cs_review-3361644-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5476  100  5476    0     0  23723      0 --:--:-- --:--:-- --:--:-- 24666
patching file fixed_block_content.module
Hunk #1 succeeded at 71 (offset 6 lines).
patching file src/DefaultContentHandler.php
patching file src/Form/ExportConfirmForm.php
patching file src/Form/FixedBlockContentDeleteForm.php
patching file src/Form/FixedBlockContentForm.php
patching file src/Plugin/Block/FixedBlockContentBlock.php
āžœ  fixed_block_content git:(8.x-1.x) āœ— cd ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig fixed_block_content

FILE: ...9/web/modules/contrib/fixed_block_content/fixed_block_content.services.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 23 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...t/tests/modules/fixed_block_content_test/fixed_block_content_test.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------


FILE: ...web/modules/contrib/fixed_block_content/fixed_block_content.links.task.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 11 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ssue-v9/web/modules/contrib/fixed_block_content/fixed_block_content.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Core\Entity\EntityFormInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/fixed_block_content/src/Form/ExportConfirmForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Form\FormStateInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/fixed_block_content/src/Form/ImportConfirmForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Form\FormStateInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...e-v9/web/modules/contrib/fixed_block_content/src/DefaultContentHandler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Cache\CacheBackendInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...9/web/modules/contrib/fixed_block_content/src/Entity/FixedBlockContent.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\block_content\BlockContentInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...es/contrib/fixed_block_content/src/Plugin/Block/FixedBlockContentBlock.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...odules/contrib/fixed_block_content/src/Routing/CompatibilitySubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Composer\Semver\Comparator.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 718ms; Memory: 12MB

    Kindly check

    Thanks,
    Jake

  • Merge request !11Issue #3361644: Fix the issues reported by phpcs ā†’ (Open) created by apaderno
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Let's use the merge request, now that patches are no longer tested.

  • Pipeline finished with Failed
    4 months ago
    Total: 141s
    #239106
  • First commit to issue fork.
  • Pipeline finished with Failed
    4 months ago
    Total: 151s
    #258874
  • Comment 4 months ago ā†’
    šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi,

    Please review MR!11. Thank you.

  • Status changed to RTBC 4 months ago
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Merge request !12Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā†’ (Open) created by apaderno
  • Pipeline finished with Failed
    4 months ago
    Total: 152s
    #259952
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    avpaderno ā†’ changed the visibility of the branch 3361644-gitlab-ci-reports to hidden.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024