Contrib.social

Remove outdated @todo in Olivero's datetime-wrapper.html.twig pointing to #3010558

Open on Drupal.org →
Created on 20 May 2023, about 2 years ago
Updated 28 June 2023, about 2 years ago

Problem/Motivation

In 📌 [META] Fix @todo items referencing closed issues Active we've discovered there's a @todo in core/themes/olivero/templates/datetime-wrapper.html.twig.
This @todo is linked to an d.o. issue that is already closed: 🐛 Unnecessary element in Umami's form-element template may produce invalid markup Fixed .

This is the @todo:

/**
 * @file
 * Theme override of a datetime form wrapper.
 *
 * @todo Refactor when https://www.drupal.org/node/3010558 is fixed.
 *
 * @see template_preprocess_form_element()
 */

Proposed resolution

[#301055] was closed as a fixed.
It removed a hardcoded <strong> tag from the error messages and replaced it with a CSS-rule.

Since core/themes/olivero/templates/datetime-wrapper.html.twig doesn't have this hardcoded <strong> tag, there's no need for refactoring.

Let's remove the now outdated @todo and move on to bigger, better and less trivial things.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

11.0 🔥

Component
Olivero  →

Last updated 9 days ago

Created by

🇳🇱Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024