Fix all the coding standards issues

I am working on this and will provide an MR.

Hi @sidharth_soman thanks for raising the issue.
I had a plan to create a new ticket to fix all the coding standards of the module, 'coz we really have a lot of issues with it.
If you don't mind, I'll use your ticket to fix all issues, not only DI.

Please review. Resolved the PHPCS issue.

HI I reviewed the MR. Scanning the phpcs it shows readme files errors . And scanning phpcs for DrupalPractice its showing errors. Please see the attached picture. Need to work on them.

I have worked on the remaining Dependency injection issues reported phpcs DrupalPractice. Please review

Thanks!

Reviewed proposed solutions (patches):

• Thanks for raising the issue but your MR doesn't fix anything but breaks the code: media_file_copy and media_entity_generator plugins and migrate-duplicate command. It looks like you just created an MR without understanding what the code does and which DI should be applied. That is, your commit had to be essentially reversed. Please, don't do like that in the future!
• @sakthi_dev and @arpitk thanks for you commits. Only small issues were fixed in your solutions. Great job!

P.S. @arpitk push your patch into the MR in the future, please. It will simplify the review process and life of the reviewers.

Done:

• Also, I used typical phpcs and phpstan configs from the D10 to recheck the module. Fixed all the other issues I found.
• Tested the module after the fixes on the empty and real projects.

P.S. Keeping a ticket in review status to allow someone else to review it. If the task remains unchanged for 2 weeks, the solution will be automatically added to the dev branch.

Automatically closed - issue fixed for 2 weeks with no activity.