- Issue created by @Shanu Chouhan
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:34pm 12 May 2023 - Status changed to Needs work
over 1 year ago 7:31pm 12 May 2023 - š®š¹Italy apaderno Brescia, š®š¹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
The command shown in the issue summary does not use the correct value for
--standard
. - Status changed to Needs review
over 1 year ago 10:15am 18 May 2023 - Status changed to Needs work
over 1 year ago 6:13pm 18 May 2023 - š®š¹Italy apaderno Brescia, š®š¹
The status is for the issue summary that needs to be updated to show the correct command used to get the report shown in the issue summary. (Hint:
phpcs --standard=Drupal/web/modules/contrib/trapadata/
will not produce any report.) - Status changed to Needs review
over 1 year ago 3:40am 19 May 2023 - Status changed to Needs work
over 1 year ago 6:35am 19 May 2023 - š®š¹Italy apaderno Brescia, š®š¹
Please see my previous comment, which explains why the status is Needs work and what needs to be done.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:24pm 19 June 2023 - š®š³India Yashaswi18
The patch provided in #7 applies cleanly, ran the phpcs command to verify , no phpcs errors or warnings remaining.
- šµšPhilippines clarkssquared
Hi
I applied MR !1 and there are few remaining PHPCS issues has been reported.
ā trapadata git:(1.0.x) curl https://git.drupalcode.org/project/trapadata/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 9553 0 9553 0 0 19321 0 --:--:-- --:--:-- --:--:-- 19696 patching file .gitlab-ci.yml patching file 'src/Form/TrapadataForm.php' patching file trapadata.module ā trapadata git:(1.0.x) ā .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml trapadata FILE: ...bing/Projects/d9/d9-local/web/modules/contrib/trapadata/trapadata.info.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 6 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...subing/Projects/d9/d9-local/web/modules/contrib/trapadata/trapadata.module -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 43 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced | | with use statements -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 198ms; Memory: 10MB ā contrib git:(master) ā
-
magulaiz ā
committed 3281c177 on 1.0.x authored by
apaderno ā
Issue #3360082: Fix the issues reported by phpcs
-
magulaiz ā
committed 3281c177 on 1.0.x authored by
apaderno ā