Contrib.social

Latest/real markup should be used when caches are enabled

Open on Drupal.org →
Created on 12 May 2023, about 1 year ago
Updated 25 May 2023, about 1 year ago

Problem/Motivation

✨ Make it easier for theme builders to enable Twig debugging and disable render cache Fixed adds a new UI for enabling development settings.

However, in comment #120 ✨ Make it easier for theme builders to enable Twig debugging and disable render cache Fixed , @crasx pointed out a weird behavior: if you have the cache enabled, you disable it and make changes, and enable it again, you get the old cached markup. This is odd and not expected, so a bad and confusing DX experience.

Steps to reproduce

  • Visit homepage with caching fully enabled (ie: nothing checked) - warms cache
  • Visit /admin/config/development/settings Check the do not cache markup checkbox / save
  • Update a twig template used on the homepage (I updated core/themes/olivero/templates/layout/html.html.twig)
  • View homepage, confirm new change appears with no cache clear
  • Visit /admin/config/development/settings Uncheck the do not cache markup checkbox / save
  • View homepage, note old cached version before the change appears

Proposed resolution

When enabling cache again, you should get the latest markup.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Postponed

Version

11.0 🔥

Component
Theme  →

Last updated 35 minutes ago

Created by

🇪🇸Spain ckrina Barcelona

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024