- Issue created by @hmdnawaz
- Status changed to Needs review
almost 2 years ago 10:13am 12 May 2023 - Assigned to arpitk
- Issue was unassigned.
- 🇮🇳India arpitk Indore
Hi @hmdnawazm, I reviewed the patch on Drupal version 9.5.8 and Taxonomy Manager version 2.0.x-dev. Installed upgrade status module and scanned Taxonomy Manager in particular. The patch #2 applied cleanly. And i can see the deprecations mention in the description are resolved. However there are still other deprecations reported as well in scan. Attaching here the screenshots for before and after applying the patch.
Before patch.
After patch
Thanks!
- Status changed to Needs work
over 1 year ago 1:14pm 28 July 2023 - 🇩🇪Germany Anybody Porta Westfalica
Back to NW as of #5 @hmdnawaz are you planning to finish this?
Any active maintainer here? The module is broken with D10 and Drupal 9 EOL is close.
- 🇵🇰Pakistan hmdnawaz
@Anybody, Yes I will add another patch to fix those other deprecations.
- 🇩🇪Germany Grevil
I'll quickly fix the remaining deprecations and notify the maintainer.
- @grevil opened merge request.
- 🇩🇪Germany Grevil
The tests were also in an incorrect folder structure, hence they don't appear on the module page (automated testing might also be deactivated).
They also fail, which is probably not related to the D10 upgrade, though.
- Status changed to Needs review
over 1 year ago 2:16pm 2 August 2023 - Status changed to RTBC
over 1 year ago 3:37pm 2 August 2023 - 🇩🇪Germany Anybody Porta Westfalica
Nice work @Grevil! Here's the CR for the deprecated function for the records: https://www.drupal.org/node/3039041 →
RTBC!
- First commit to issue fork.
-
VladimirAus →
committed cd7979e8 on 2.0.x authored by
hmdnawaz →
Issue #3359888 by Grevil, hmdnawaz, arpitk, Anybody, VladimirAus: Drupal...
-
VladimirAus →
committed cd7979e8 on 2.0.x authored by
hmdnawaz →
- Status changed to Fixed
over 1 year ago 1:27pm 9 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.