- Issue created by @himanshu_jhaloya
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:01am 11 May 2023 - ๐ฎ๐ณIndia arpitk
Hi @himanshu_jhaloya I reviews the MR and it fixes all reported issues no more warning or error to be fixed. Here attaching screenshots for before and after fix.
After fix running phpcs --standard=Drupal,DrupalPractice returns clean.
Thanks!
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The report given in the issue summary is not correct: It reports warnings for the walkme.info.yml file, but that file does not have lines that needs to be removed.
name: WalkMe Integration type: module description: 'Very basic module for implementing WalkMeโข within Drupal.' core_version_requirement: ^8 || ^9 || ^10 package: WalkMe configure: admin/config/system/walkme
- Status changed to Needs work
over 1 year ago 8:31pm 11 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
If I run the command shown in the issue summary, I get a longer report. I am going to update the issue summary in minutes.
- Status changed to Needs review
over 1 year ago 8:38pm 11 May 2023 - Status changed to Needs work
over 1 year ago 8:50pm 11 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
-Before installing this module go to walkme.com, generate the script and publish script. -After module is installed navigate to admin/config/system/walkme and place walkme script in Script field. - +Before installing this module go to walkme.com, +generate the script and publish script. +After module is installed navigate to +admin/config/system/walkme and place walkme script in Script field.
Avoiding that lines exceed 80 characters does not mean shorting them to 40 characters or less. There is no rule that says lines must be split after punctuation marks.
It does not seem the MR is removing one of the newlines found at the end of the README.md file.
/** - * Class WalkmeForm. + * The WalkmeForm class extends the ConfigFormBase class and represents a form.
That description does not describe what that class does, except saying it represent a form, which is implicit in the class name.
A class description must not say which is the parent class nor repeat the class name. - Assigned to imustakim
- @imustakim opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:25am 12 May 2023 - Status changed to RTBC
6 months ago 12:37pm 7 June 2024 Hi @imustakim,
Applied your latest changes on MR !6 against 8.x-1.x version, it applied not-so successfully but it fixed all errors. Please see below:
walkme git:(8.x-1.x) โ curl https://git.drupalcode.org/project/walkme/-/merge_requests/6.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3278 0 3278 0 0 7283 0 --:--:-- --:--:-- --:--:-- 7484 patching file README.md Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file README.md.rej patching file src/Form/WalkmeForm.php patching file walkme.routing.yml โ walkme git:(8.x-1.x) โ cd .. โ contrib git:(main) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig walkme โ contrib git:(main) โ
Will move this to RTBC
Thanks,
Jake- Status changed to Needs review
6 months ago 5:02pm 7 June 2024