[8.x-1.x] SASS Compile

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Fix PHPCS issue.

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,php web/modules/sass_compile/

FILE: /web/modules/sass_compile/README.md
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
28 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: /web/modules/sass_compile/src/SassCompileService.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
12 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
69 | WARNING | [x] There must be no blank line following an inline comment
69 | WARNING | [ ] There must be no blank line following an inline comment
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/sass_compile/src/Form/SassCompileConfigForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/sass_compile/src/SassCompileServiceInterface.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
7 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/sass_compile/src/Commands/SassCompileCommands.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /web/modules/sass_compile/sass_compile.info.yml
-----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------

Remove the commented line from SassCompileService.php.

       // Other possible formatters:
          // Leafo\ScssPhp\Formatter\Expanded
          // Leafo\ScssPhp\Formatter\Nested (default)
          // Leafo\ScssPhp\Formatter\Compressed
          // Leafo\ScssPhp\Formatter\Compact
          // Leafo\ScssPhp\Formatter\Crunched.

Fixed https://www.drupal.org/project/projectapplications/issues/3359554#commen... → and https://www.drupal.org/project/projectapplications/issues/3359554#commen... →

Its looks fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

1. Fix phpcs issue.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml sass_compile/

FILE: sass_compile/src/SassCompileService.php
-----------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------
 45 | ERROR | Type hint "null" missing for $source
 45 | ERROR | Type hint "null" missing for $destination
-----------------------------------------------------------------------------

2. master is a wrong branch name, as branch names end with the literal .x. That branch needs to be removed.

3. FILE: sass_compile.info.yml

package: 'Custom'

Modules should avoid using that value for the package.

Thanks @vishalkadam
1. Fix phpcs issue. - $source,$destination fetching value from settings that's why putted null value
2.Removed Master branch
3. Removed Package

Rest looks fine to me.

Any opinions on this modules? I am waiting for the role.

Looking through the commit logs, it appears to me the majority of the commits are not authored by the applicant.

The only commits directly attributable to the applicant are those that originated as part of this review. The commits that we’re authored by the applicant mostly involve removing code, or what could be automated PHPCS fixes.

Even if the commits where @kpoornima is listed
As the committer with another individual indicated as the author were included I don’t believe there is enough code to judge the applicants ability to write PHP code.

To make the previous comment clearer, this application needs another project to review.

For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not what all the people who can commit on the project repository collectively understand about those points.

This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.