Fix the issues reported by phpcs

I am working on this and will provide an MR.

Since there are not patches nor MRs, the status is still Active.

I still getting this

FILE: /home/drupal/serial/src/SerialSQLStorage.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 150 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead

FILE: /home/drupal/serial/src/Plugin/Field/FieldFormatter/SerialDefaultFormatter.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 33 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------

Time: 275ms; Memory: 10MB

the output of phpcs -i:

The installed coding standards are MySource, PEAR, PSR1, PSR2, PSR12, Squiz, Zend, Drupal, DrupalPractice, VariableAnalysis and SlevomatCodingStandard

Please review.

+  /**
+   * Drupal\Core\Render\RendererInterface definition.
+   *
+   * @var \Drupal\Core\Render\RendererInterface
+   */
+  protected $renderer;

The short description must not repeat the class name (which is already given in the @var line) nor contain just the class name and definition. (Drupal\Core\Render\RendererInterface definition. is not even correct, since a class property is not an interface definition.)

+  /**
+   * {@inheritdoc}
+   */
+  public function __construct(RendererInterface $renderer) {
+    $this->renderer = $renderer;
+  }

{@inheritdoc} is not used in documentation comments for constructors.
The description for a constructor must start with Constructs a new followed by the class name (including its namespace), and end with object.
The documentation description for a constructor must describe its parameters.

+  /**
+   * {@inheritdoc}
+   */
+  public function __construct(RendererInterface $renderer) {
+    $this->renderer = $renderer;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public static function create(ContainerInterface $container) {
+    return new static(
+      $container->get('renderer')
+    );
+  }

Since this class extends FormatterBase, that code is not correct. The parent class constructor is not called.

-          \Drupal::messenger()->addMessage(t('Serial values have been automatically set for %count existing entities, starting from %start_value.', [
+          \Drupal::messenger()->addMessage($this->t('Serial values have been automatically set for %count existing entities, starting from %start_value.', [

The messenger should be injected too, or phpcs would still complain with \Drupal calls should be avoided in classes, use dependency injection.

+  /**
+   * Constructs a new SerialDefaultFormatter object.
+   *
+   * @param \Drupal\Core\Render\RendererInterface $renderer
+   *   The renderer.
+   */
+  public function __construct(RendererInterface $renderer) {
+    $this->renderer = $renderer;
+  }

The class name is still missing its namespace.
What is more important, the constructor is not calling the constructor for the parent class, the create() method is missing.
This means the changed code does not work. I would suggest to check what a class like OEmbedFormatter does.

Since that is introducing a bug in the code, that must be immediately corrected.

Hey, if you get lost just follow this guide → .

This was fixed on dev, can anyone please review, thanks.

This is an issue that reports only PHP_CodeSniffer warnings/errors.

Can anyone review this so we can change to RTBC, thanks.

Released a new version with this fix, thanks to all.

Automatically closed - issue fixed for 2 weeks with no activity.