Resolve test failures on 11.x branch

17 failures on https://www.drupal.org/pift-ci-job/2662465 →

Here's a start.

This should resolve most/all of the help_topics failures.

This fixes fatal errors in a locale test but not the actual failure, which might be down to l.d.o

The last submitted patch, 3: 3359077.patch, failed testing. View results →

The last submitted patch, 4: 3359077-4.patch, failed testing. View results →

The last submitted patch, 5: 3359077-5.patch, failed testing. View results →

Skipping the remaining tests for now. We can probably make them work with 11.x (not sure if they should though), but no idea what we'll do once we have a 'main' branch with no version number.

The last submitted patch, 9: 3359077-9.patch, failed testing. View results →

The two locale tests are failing in ::setUp() before we try to skip the test, so also need an early return.

Thanks phpcs...

1. +++ b/core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherUserTest.php
   @@ -91,7 +91,7 @@ public function providerShowAnnouncements(): array {
   -          'version' => '^10',
   +          'version' => '^11',
   

   I think it's worth making this dynamic so we don't have to change this on every major Drupal version.

2. +++ b/core/modules/locale/tests/src/Functional/LocaleNonInteractiveInstallTest.php
   @@ -32,7 +32,10 @@ protected function getVersionStringToTest() {
       * {@inheritdoc}
       */
      protected function installParameters() {
   +    // phpcs:disable
        $parameters = parent::installParameters();
   +    // Skipped because this branch can't be translated.
   +    return $parameters;
        // Install Drupal in German.
        $parameters['parameters']['langcode'] = 'de';
        // Create a po file so we don't attempt to download one from
   @@ -49,12 +52,15 @@ protected function installParameters() {
   
   @@ -49,12 +52,15 @@ protected function installParameters() {
        $version = $this->getVersionStringToTest();
        file_put_contents($this->publicFilesDirectory . "/translations/drupal-{$version}.de.po", $contents);
        return $parameters;
   +    // phpcs::enable
      }
    
      /**
       * Tests that the expected translated text appears on the login screen.
       */
      public function testInstallerTranslations() {
   +    // Skipped because this branch can't be translated.
   +    $this->markTestSkipped();
        $this->drupalGet('user/login');
        // cSpell:disable-next-line
        $this->assertSession()->responseContains('Geben sie das Passwort für ihren Benutzernamen ein.');
   

   Let's add a skip test in a new setUp implementation - then we wouldn't need to mess with PHPCS

What I mean by #13.2 is add this:

  /**
   * {@inheritdoc}
   */
  protected function setUp(): void {
    // Skipped because this branch can't be translated.
    $this->markTestSkipped();
    parent::setUp();
  }

Calling $this->markTestSkipped(); prior to the parent::setUp() is the most efficient way to skip a test as you don't even do an install.

#13.1 @xjm mentioned in slack just skipping everything here and adding a follow-up to make things dynamic, switching over to that and will open the follow-up in a bit.

#13.2 ahh nice that crossed my mind but I didn't know whether it actually worked! Much better.

Opened 🌱 Fix the various tests fail every time we open a new major branch and unskip them on the 11.x branch Active .

+++ b/core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php
@@ -55,6 +55,8 @@ public function setUp():void {
+    // Skipped due to version-specific logic.
+    $this->markTestSkipped();

+++ b/core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherTest.php
@@ -29,6 +29,8 @@ protected function setUp(): void {
+    // Skipped due to version-specific logic.
+    $this->markTestSkipped();

Should it be a @todo with link to the new issue?

Discussed the @todo with @catch we agreed that as long as with have a critical issue open to fix them this is fine.

+    // Skipped due to version-specific logic.
+    $this->markTestSkipped();

Should be
$this->markTestSkipped('Skipped due to version-specific logic.')

This way PHPUnit output is even more helpful.

Reworked things so the reason we skip is inside the messages including the follow-up issue link.

Ugh stray space bar..

Dodgy space bar.

Looks great and good to go!

Follow-up exists 🌱 Fix the various tests fail every time we open a new major branch and unskip them on the 11.x branch Active

Committed 861648c and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.