- Issue created by @Nishant
- @nishant opened merge request.
- @nishant opened merge request.
- Status changed to Needs review
over 1 year ago 8:24am 9 May 2023 - Status changed to Needs work
over 1 year ago 11:18am 9 May 2023 - 🇮🇳India Shiv_Sharma
@nishant reviewed the code but seems the is indentation issue
public static function getSubscribedEvents() { $events[KernelEvents::REQUEST][] = ['onKernelRequestCheckKeycloakRedirect', 35 ];
It should be look like this.
public static function getSubscribedEvents() { $events[KernelEvents::REQUEST][] = [ 'onKernelRequestCheckKeycloakRedirect', 35 ];
- Status changed to Needs review
over 1 year ago 11:31am 9 May 2023 - Status changed to RTBC
over 1 year ago 11:58am 9 May 2023 - 🇮🇳India Shiv_Sharma
@nishant seems no new error from PHPCS.
attached screenshot for reference - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Normally I don't give credit for such automated fix, but I assume that this is a "intro to contributing" kind of thing, and since the review actually was a proper review, I'll give credit this time.
-
BramDriesen →
committed 84ce41df on 2.2.x authored by
Nishant →
Issue #3359028 by Nishant, Shiv_Sharma: Fix the issues reported by phpcs
-
BramDriesen →
committed 84ce41df on 2.2.x authored by
Nishant →
- Status changed to Fixed
over 1 year ago 1:03pm 9 May 2023 - Status changed to Needs review
over 1 year ago 1:40pm 9 May 2023 - Status changed to Fixed
over 1 year ago 1:42pm 9 May 2023 - Issue was unassigned.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Giving credit to @apaderno as well for keeping issues in their correct state 😉
Automatically closed - issue fixed for 2 weeks with no activity.