- Issue created by @mcdruid
- Status changed to Needs review
over 1 year ago 4:33pm 12 May 2023 - last update
over 1 year ago 29,388 pass - 🇸🇰Slovakia poker10
Here is the patch similar to the D7 one, which uses the static
Settings::get()
(instead of injecting the Settings to theSystemInfoController
). Let's check the testbot. - Status changed to Needs work
over 1 year ago 9:16pm 12 May 2023 - 🇺🇸United States smustgrave
Can we add a simple change record for the new setting being proposed
Thanks!
- Status changed to Needs review
over 1 year ago 10:20am 13 May 2023 - 🇸🇰Slovakia poker10
Thanks for the suggestion! Created a draft CR here: https://www.drupal.org/node/3360166 → . Text is similar to the one we are adding as docs in the
settings.php
. - Status changed to RTBC
over 1 year ago 3:19pm 13 May 2023 - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass The last submitted patch, 3: 3358514-3.patch, failed testing. View results →
- last update
over 1 year ago 29,388 pass - 🇸🇰Slovakia poker10
Seems like a testbot issue, moving back to RTBC.
- 🇮🇳India shashank5563 New Delhi
I have test on my and found everything is looks good. I am moving to RTBC+1
- last update
over 1 year ago 29,387 pass, 2 fail The last submitted patch, 3: 3358514-3.patch, failed testing. View results →
- last update
over 1 year ago 29,385 pass, 4 fail - last update
over 1 year ago 29,387 pass, 2 fail - last update
over 1 year ago 29,387 pass, 2 fail - last update
over 1 year ago 29,388 pass - 🇸🇰Slovakia poker10
Seems like there are issues with 10.1.x core tests, see: https://www.drupal.org/pift-ci-job/2666817 →
Restoring status.
- last update
over 1 year ago 29,388 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,396 pass - 🇬🇧United Kingdom catch
Patch looks fine but this needs a change record and release note mentioning the setting.php changes.
- last update
over 1 year ago 29,398 pass - 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
I think we've got the draft CR linked already; we can add a release note snippet to the IS.
- 🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺
Added a release note snippet.
@catch, please let us know if this needs anything else. Thanks!
- Status changed to Fixed
over 1 year ago 11:24am 26 May 2023 - 🇩🇰Denmark ressa Copenhagen
Adding link to https://www.drupal.org/sa-core-2023-004 → in Issue Summary.
- 🇳🇿New Zealand quietone
Added branch/version to the CR and published it.
Automatically closed - issue fixed for 2 weeks with no activity.