- Issue created by @sidharth_soman
- 🇮🇳India sidharth_soman Bangalore
I am finding the above issues after running the phpcs command. I will work on them.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 11:36am 5 May 2023 - 🇮🇳India sidharth_soman Bangalore
I've solved all issues except for the dependency injection and minor requirements of editing/filling in documentation. This should ideally be resolved by the maintainer.
I've opened an MR above. Please review.
- Status changed to Needs work
almost 2 years ago 7:16pm 5 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- Status changed to Needs review
almost 2 years ago 8:04am 8 May 2023 - Status changed to Needs work
almost 2 years ago 8:25am 8 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- // TODO: support other field types? + // @todo support other field types?
What follows
@todo
is a sentence: It starts with a capitalized word and end with a period (preferable), a question mark, or an exclamation point. In this case, Consider supporting other field types. is a better sentence.+/** + * + */ class TestAddToCal extends AddToCal {
Documentation comments for classes must describe the class purpose.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:26am 11 May 2023 - 🇨🇦Canada imustakim Canada
Patch and issue summary updated.
Please review. - Status changed to Needs work
almost 2 years ago 11:46am 11 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
/** * @file - * Contains addtocal_augment.module. + * Hook implementation for the Add to Calendar Date Augmenter module. */
It should be Hook implementations.
/** - * Override parent::defaultConfiguration() - * which uses String Translation. + * Override parent::defaultConfiguration() which uses String Translation.
It should be either string translation or StringTranslationTrait, if it is referring to the trait used by the parent class.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 12:33pm 11 May 2023 - 🇮🇳India arpitk Indore
Hi I reviews the patch and it applied cleanly. Running phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js . after patch results no warnins or errors. Here attaching the screenshots.
Thanks!
- First commit to issue fork.
- Status changed to Fixed
over 1 year ago 6:07pm 21 December 2023 -
mark_fullmer →
committed 2df18aac on 1.1.x authored by
sidharth_soman →
Issue #3358361 by imustakim: Fix the issues reported by phpcs
-
mark_fullmer →
committed 2df18aac on 1.1.x authored by
sidharth_soman →
- 🇺🇸United States mark_fullmer Tucson
Valid PHPCS and PHPStan warnings are now handled. I opted to add "ignore" statements for the PHPStan warning about not using dependency injection, since I think the conditional usage of the Token service here makes more sense as a direct call.
ESlinting is still reporting violations, but I'm not convinced that those are quite valid, based on discussion in 📌 JS closure results in "Unexpected unnamed function" warning from eslint Closed: won't fix , so leaving as-is.
One of the PHPCS warnings was about
augmentOutput()
needing areturn
statement, sincedate_augmenter/src/DateAugmenter/DateAugmenterInterface
states that requirement, but I think that is incorrect based on usage and needs to be updated. I added an innocuous return for now to satisfy the Interface and will follow-up in the DateAugmenter module. Automatically closed - issue fixed for 2 weeks with no activity.