- Issue created by @vishalkhode
- First commit to issue fork.
- last update
over 1 year ago 63 pass - @rajeshreeputra opened merge request.
- last update
over 1 year ago 62 pass, 2 fail - last update
over 1 year ago 57 pass, 6 fail - last update
over 1 year ago 63 pass - last update
over 1 year ago 62 pass, 2 fail - last update
over 1 year ago 62 pass, 2 fail - last update
over 1 year ago 62 pass, 2 fail - last update
over 1 year ago 62 pass, 2 fail - Status changed to Needs review
over 1 year ago 5:15am 15 May 2023 - Assigned to ankitv18
- last update
over 1 year ago 63 pass - 🇮🇳India ankitv18
All changes are looking fine to me wrt Drupal version 10.0.7 and below tested with PHP 8.1 and 8.2 ~~ Hence marking this as RTBC.
Note: One test case is failing against for Drupal version 10.1.x with php 8.2
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 9:15am 15 May 2023 - last update
over 1 year ago 62 pass, 2 fail - last update
over 1 year ago 62 pass, 2 fail - last update
over 1 year ago 63 pass - Status changed to Needs work
over 1 year ago 11:20am 16 May 2023 - 🇨🇭Switzerland berdir Switzerland
Review posted. Try to avoid unrelated changes, the only really required change here that is in scope is defining the new properties.
- last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 62 pass, 2 fail - last update
over 1 year ago 63 pass - Status changed to Needs review
over 1 year ago 4:22am 18 May 2023 - 🇮🇳India ankitv18
Please review MR!47, FunctionalJavascriptTest is failing on Drupal 10.1 caused by bulk operation with default option as -select-
Attaching the screenshot for your reference.
- last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 62 pass, 2 fail - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - last update
over 1 year ago 63 pass - Status changed to RTBC
over 1 year ago 11:23am 18 May 2023 - Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Assigning to myself as I'm triaging all RTBC issues.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Been reviewing the comments and the commits and diffing things. Having the coding standard changes in it MR does make it harder to review which is something @Berdir mentioned above.
All permutations of tests have been run and pass which is good. I'm just trying to decide if this should be manually tested on all these version but that would be a bit labor intensive. Also, the info file has
^9.2
so I'll fire up tests for that at least to see what happens. - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Testing on 9.2 + PHP 8.0 went well.
- heddn Nicaragua
I've tested w/ PHP 8.2 and Core 10.1. Without the patch, when I went to re-save all views, I got warnings about dynamic properties. With the patch, I no longer get those warnings.
Tested using
drush php
:$entities = \Drupal::entityTypeManager()->getStorage('view')->loadMultiple(); foreach ($entities as $entity) {$entity->save();}
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks @heddn. If this can be tested on 9.2 with PHP 7.4 then I'd feel comfortable merging it.
- Issue was unassigned.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Unassigning from me for now as I'm going to be on vacation for awhile and not sure when I could test this.
- 🇮🇳India vipin.mittal18 Greater Noida
Does anything block the stable release with PHP 8.2 deprecation fixes?
- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago 63 pass - last update
about 1 year ago 63 pass -
Berdir →
committed db201633 on 8.x-1.x authored by
Rajeshreeputra →
Issue #3357833 by Rajeshreeputra, ankitv18, Kristen Pol, andre.bonon,...
-
Berdir →
committed db201633 on 8.x-1.x authored by
Rajeshreeputra →
- Status changed to Fixed
about 1 year ago 10:41am 30 August 2023 - 🇨🇭Switzerland berdir Switzerland
Merged, thanks for your contributions.
Again, try to limit changes to what is actually required in an issue, that makes it far easier to review and get committed.
Automatically closed - issue fixed for 2 weeks with no activity.