Contrib.social

Remove remaining uses of string 'bartik' and 'seven' when referring to the removed themes

Open on Drupal.org →
Created on 2 May 2023, about 1 year ago
Updated 23 April 2024, about 2 months ago

Problem/Motivation

There are some instances the strings referring to the removed themes, 'Bartik' and 'Seven'.

Steps to reproduce

$ git grep -i bartik | grep -iv migrat | grep -v fixtures | grep -v system.install | grep -v form.css
core/misc/cspell/dictionary.txt:bartik
core/misc/dialog/off-canvas/css/form.pcss.css:  & legend, /* Bartik doesn't apply BEM classes, so we use the element. */
core/misc/dialog/off-canvas/css/form.pcss.css:  /* Bartik uses the .field-multiple-table CSS class on its tabledrag tables. */
core/tests/README.md:  `yarn test:nightwatch --tag a11y:default --defaultTheme bartik`

$ git grep -wi seven | grep -iv migrat | grep -v fixtures | grep -v system.install | grep -v form.css
core/modules/jsonapi/tests/src/Functional/TermTest.php:      ->setDescription("It is a little known fact that llamas cannot count higher than seven.")
core/modules/jsonapi/tests/src/Functional/TermTest.php:            'value' => 'It is a little known fact that llamas cannot count higher than seven.',
core/modules/jsonapi/tests/src/Functional/TermTest.php:            'processed' => "<p>It is a little known fact that llamas cannot count higher than seven.</p>\n",
core/modules/system/tests/src/Functional/UpdateSystem/UpdateScriptTest.php:          'theme' => ['seven'],
core/modules/system/tests/src/Functional/UpdateSystem/UpdateScriptTest.php:          'theme' => ['seven'],
core/modules/taxonomy/tests/src/Functional/Rest/TermResourceTestBase.php:      ->setDescription("It is a little known fact that llamas cannot count higher than seven.")
core/modules/taxonomy/tests/src/Functional/Rest/TermResourceTestBase.php:          'value' => 'It is a little known fact that llamas cannot count higher than seven.',
core/modules/taxonomy/tests/src/Functional/Rest/TermResourceTestBase.php:          'processed' => "<p>It is a little known fact that llamas cannot count higher than seven.</p>\n",
core/modules/views_ui/tests/src/Functional/ViewEditTest.php:    $edit = ['display_comment' => 'one two three four five six seven eight nine ten eleven twelve thirteen fourteen fifteen'];
core/modules/views_ui/tests/src/Functional/ViewEditTest.php:    $this->assertSession()->pageTextContains('one two three four five six seven eight nine ten eleven twelve thirteen fourteen...');
core/tests/Drupal/Tests/Core/Render/RendererPlaceholdersTest.php:    // Case seven: render array that has a placeholder that is:
core/tests/README.md:  `yarn test:nightwatch --tag a11y:admin --adminTheme seven`

system.install is ignored because it has a list of removed themes.

Proposed resolution

Remove usage of string 'bartik' and 'seven' when used to refer to a theme.

Remaining tasks

Patch
Also remove from dictionary and rebuild dictionary to see if the word can be removed.

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.3 ✨

Component
Theme  →

Last updated about 3 hours ago

Created by

🇳🇿New Zealand quietone New Zealand

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024