Fix the issues reported by phpcs

FILE: /home/system/Documents/contribution/pager_serializer-3356754/src/Plugin/views/style/PagerSerializer.php ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 47 | ERROR | [x] Expected "\Drupal\Core\Extension\ModuleHandlerInterface" but found "\Drupal\Core\Extension\ModuleHandlerInterface;" for @var tag in member variable comment ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /home/system/Documents/contribution/pager_serializer-3356754/tests/src/Unit/Plugin/views/style/SerializerTest.php ------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------------------ 37 | ERROR | [x] Expected "\Drupal\Core\Extension\ModuleHandler" but found "\Drupal\Core\Extension\ModuleHandler;" for @var tag in member variable comment ------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /home/system/Documents/contribution/pager_serializer-3356754/pager_serializer.api.php ------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------- 11 | ERROR | [x] There must be no blank lines after the function comment ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- Time: 140ms; Memory: 14MB

Comments & Activities

Issue created by @dineshkumarbollu
Issue was unassigned.
Status changed to Needs review over 1 year ago4:28am 27 April 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
15 pass, 2 fail
Comment over 1 year ago →
🇮🇳India dineshkumarbollu
Hi

I fix all the issues except "Unused variable $response"

Please review.
Comment over 1 year ago →
System Message
The last submitted patch, 2: codingstandards-3356754-2.patch, failed testing. View results →
Status changed to Needs work over 1 year ago7:28am 27 April 2023
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
16 pass
First commit to issue fork.
Assigned to nitin_lama
Comment over 1 year ago →
🇮🇳India nitin_lama
Comment over 1 year ago →
🇮🇳India nitin_lama
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
15 pass, 2 fail
@nitin_lama opened merge request.
Issue was unassigned.
Comment over 1 year ago →
🇮🇳India nitin_lama
MR for #2.

"Unused variable $response" still need to be addressed.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs review over 1 year ago4:25am 30 May 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
15 pass, 2 fail
Comment over 1 year ago →
Neeraj333
Comment over 1 year ago →
System Message
The last submitted patch, 11: fix_coding_standard-3356754-11.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
15 pass, 2 fail
Comment about 1 year ago →
System Message

bluegeek9 → committed ce12b421 on 8.x-1.x authored by nitin_lama →
Issue #3356754 by Neeraj333: Fix the issues reported by phpcs
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
15 pass, 2 fail
@bluegeek9 opened merge request.
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
15 pass, 2 fail
Comment about 1 year ago →
System Message

bluegeek9 → authored b2ac7718 on 8.x-1.x
Issue #3356754 by bluegeek9, nitin_lama, Neeraj333: Fix the issues...
Status changed to Fixed about 1 year ago5:55pm 5 September 2023
Comment about 1 year ago →
🇺🇸United States bluegeek9
Comment 12 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Proposed resolution

Comments & Activities