Display plus sign once on inline block create button with Stable9 theme

Issue created by @daddison
Status changed to Postponed: needs info about 2 years ago11:14pm 25 April 2023
Comment about 2 years ago →
🇳🇿New Zealand danielveza Brisbane, AU
I've tested this with just core and I haven't been able to replicate this. Do you have a custom theme or contributed themes/modules that might be interferring here?
Comment about 2 years ago →
🇳🇿New Zealand danielveza Brisbane, AU
Status changed to Closed: works as designed about 2 years ago4:28pm 26 April 2023
Comment about 2 years ago →
🇺🇸United States mark_fullmer Tucson
Our team was also able to determine that this does not happen on a standard Drupal installation, and have isolated code in a custom theme that seems to be triggering it. Closing this issue as "Works as designed."
Status changed to Active about 2 years ago5:19pm 26 April 2023
Comment about 2 years ago →
🇺🇸United States mark_fullmer Tucson
Additional information on this. The problem is triggered when the Stable 9 theme is used. Updating the steps to reproduce in this issue, and re-opening as "Active."
Status changed to Needs review about 2 years ago5:55pm 28 April 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 2 years ago
Patch Failed to Apply
Comment about 2 years ago →
🇺🇸United States daddison
Patch removes extraneous styling for inline block create button in stable9 theme.
Status changed to Needs work almost 2 years ago8:47pm 29 April 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Think some before/after screenshots would be useful for an issue like this.
Comment almost 2 years ago →
🇺🇸United States daddison
I re-rolled the patch against drupal/drupal, rather than drupal/core. Before and after screenshots attached.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,366 pass
Status changed to RTBC almost 2 years ago2:57pm 1 May 2023
Comment almost 2 years ago →
🇺🇸United States mark_fullmer Tucson
I was able to reproduce the issue:

1. Drupal 10.1.x-dev
2. Setting Stable 9 as the active theme via config-set system.theme default stable9
3. Enable layout_builder
4. Set the page node type display to use Layout Builder and to allow overrides on individual nodes.
5. Create a node of type "page" and use Layout Builder, clicking "Add block".

I verified that the patch in #8 removes the duplicated plus sign.

I also agree with the rationale of removing this declaration from Stable9, since the Layout Builder module is providing default styling for this plus sign and there is no reason for Stable9 to override it. This clearly was just legacy CSS that wasn't cleaned up with the update to Drupal 10 and changes in the Layout Builder module.

Marking as "Reviewed and Tested by the Community."
Comment almost 2 years ago →
🇦🇺Australia pameeela
Switching back to bug report since there is a patch that needs committing.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,371 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,378 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,379 pass
Comment almost 2 years ago →
🇳🇿New Zealand quietone
Just a title change.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,380 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,383 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,387 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
28:36
24:58
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,396 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,399 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,399 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,400 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,400 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,409 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,415 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,425 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,429 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,436 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,436 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,436 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,442 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,443 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MariaDB 10.3.22
last update almost 2 years ago
29,443 pass
Comment almost 2 years ago →
System Message

larowlan → committed a1492698 on 10.1.x
Issue #3356408 by daddison, mark_fullmer, smustgrave: Display plus sign...
Comment almost 2 years ago →
System Message

larowlan → committed 7e5b0739 on 11.x
Issue #3356408 by daddison, mark_fullmer, smustgrave: Display plus sign...
Status changed to Fixed almost 2 years ago7:15am 3 July 2023
Comment almost 2 years ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed 7e5b073 and pushed to 11.x. Thanks!

Back-ported to 10.1.x
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Display plus sign once on inline block create button with Stable9 theme

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities