- Issue created by @dineshkumarbollu
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:17am 18 April 2023 - š®š³India dineshkumarbollu
I fixed all coding standards issue except this because maintainer can know about it, how it will useful in code
FILE: /var/www/html/drupalvb/web/modules/contrib/livechat/src/Form/HideLiveChatSettingsForm.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
51 | WARNING | Unused variable $value. - š®š³India Manoj Raj.R Chennai
Reviewed and changes looks good to me.
Can be moved to RTBC. other than @dineshkumarbollu mentioned needs to be reviewed by Maintainer.
- Status changed to Needs work
5 months ago 1:40am 23 July 2024 Hi @dineshkumarbollu @Manoj Raj.r,
Applied the patch @dineshkumarbollu provided, it was applied successfully but there still errors reported. Please see below:
livechat git:(8.x-3.x) curl https://www.drupal.org/files/issues/2023-04-18/codingstandards-3354770-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5487 100 5487 0 0 31074 0 --:--:-- --:--:-- --:--:-- 38104 patching file README.md patching file config/install/livechat.settings.yml patching file config/schema/livechat.schema.yml patching file css/livechat.css patching file livechat.info.yml patching file src/Controller/LivechatController.php patching file src/Form/HideLiveChatSettingsForm.php ā livechat git:(8.x-3.x) ā cd .. ā contrib git:(master) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig livechat FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/livechat/src/Form/HideLiveChatSettingsForm.php -------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------- 51 | WARNING | Unused variable $value. -------------------------------------------------------------------------------------------------------------------------- FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/livechat/src/Controller/LivechatController.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\JsonResponse. --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- Time: 261ms; Memory: 10MB
Kindly check
Thanks,
Jake- First commit to issue fork.
- Status changed to Needs review
5 months ago 3:50am 23 July 2024 - Assigned to dev2.addweb
- š®š³India dev2.addweb
I have applied the patch cleanly, and the above errors are resolved.
Please check the Screenshots for the same. - Issue was unassigned.
- Status changed to RTBC
5 months ago 5:46am 23 July 2024