Contrib.social
Created on 18 April 2023, over 1 year ago
Updated 23 July 2024, 4 months ago

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/livechat/

FILE: ...ml/drupalvb/web/modules/contrib/livechat/config/schema/livechat.schema.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...drupalvb/web/modules/contrib/livechat/config/install/livechat.settings.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...rupalvb/web/modules/contrib/livechat/src/Controller/LivechatController.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
14 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
61 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

FILE: ...rupalvb/web/modules/contrib/livechat/src/Form/HideLiveChatSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
10 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
36 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
36 | WARNING | Translatable strings must not begin or end with white spaces,
| | use placeholders with t() for variables
51 | WARNING | Unused variable $value.
--------------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/livechat/css/livechat.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
107 | ERROR | [x] Multiple selectors should each be on a single line
189 | ERROR | [x] Multiple selectors should each be on a single line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/livechat/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------
5 | WARNING | [ ] Line exceeds 80 characters; contains 277 characters
27 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: /var/www/html/drupalvb/web/modules/contrib/livechat/livechat.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 450ms; Memory: 12MB

šŸ“Œ Task
Status

RTBC

Version

3.0

Component

Code

Created by

šŸ‡®šŸ‡³India dineshkumarbollu

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dineshkumarbollu
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India dineshkumarbollu

    I fixed all coding standards issue except this because maintainer can know about it, how it will useful in code

    FILE: /var/www/html/drupalvb/web/modules/contrib/livechat/src/Form/HideLiveChatSettingsForm.php
    -----------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------
    51 | WARNING | Unused variable $value.

  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India Manoj Raj.R Chennai

    Reviewed and changes looks good to me.

    Can be moved to RTBC. other than @dineshkumarbollu mentioned needs to be reviewed by Maintainer.

  • Status changed to Needs work 4 months ago
  • Comment 4 months ago ā†’
    a.aaronjake

    Hi @dineshkumarbollu @Manoj Raj.r,

    Applied the patch @dineshkumarbollu provided, it was applied successfully but there still errors reported. Please see below:

    livechat git:(8.x-3.x) curl https://www.drupal.org/files/issues/2023-04-18/codingstandards-3354770-2.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5487  100  5487    0     0  31074      0 --:--:-- --:--:-- --:--:-- 38104
patching file README.md
patching file config/install/livechat.settings.yml
patching file config/schema/livechat.schema.yml
patching file css/livechat.css
patching file livechat.info.yml
patching file src/Controller/LivechatController.php
patching file src/Form/HideLiveChatSettingsForm.php
āžœ  livechat git:(8.x-3.x) āœ— cd ..
āžœ  contrib git:(master) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig livechat

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/livechat/src/Form/HideLiveChatSettingsForm.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
 51 | WARNING | Unused variable $value.
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/livechat/src/Controller/LivechatController.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\JsonResponse.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

Time: 261ms; Memory: 10MB

    Kindly check

    Thanks,
    Jake

  • First commit to issue fork.
  • Merge request !4Issue #3354770:fixed phpcs issues. ā†’ (Open) created by Unnamed author
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡³India atul_ghate
  • Assigned to dev2.addweb
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡³India dev2.addweb
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡³India dev2.addweb

    I have applied the patch cleanly, and the above errors are resolved.
    Please check the Screenshots for the same.

  • Issue was unassigned.
  • Status changed to RTBC 4 months ago
  • Comment 4 months ago ā†’
    šŸ‡®šŸ‡³India dev2.addweb
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024