Regression updating to 3.1.22 for Drupal 9.x using loadTemplate from twig

Same issue. Site broken by this update.

The patch fixes the crash, but I still have a problem with my D9 :
The information doesn't update on term change.
I get a JS error : this.document.querySelector(...) is null
The selector '#edit-permissions-by-term-info .js-form-type-item' doesn't match the DOM structure.
Mine would be : '#edit-permissions-by-term-info .details-wrapper'

@emmguyot can you create another issue for your case, so it can be resolved in it?
This issue is relative to twig update and loadTemplate method.

Thanks

The patch works beautifully. Please roll this as a release; if anyone had the same issues we had, you'll save hours of debug time for other folks...

I'm not seeing a patch here for version 3.1.22, is there one?

This is same issue I'm seeing as reported here:
https://www.drupal.org/project/permissions_by_term/issues/3289053#commen... 📌 Automated Drupal 10 compatibility fixes for Permissions by Term Fixed

I confirm that the patch : https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/...
Works for me, thank you !

Confirmed this patch works on my site. Thanks!

Confirmed this fix works with D9.5.8

@wheelercreek the patch is the drupalcode link above, or as plain diff it's
https://git.drupalcode.org/issue/permissions_by_term-3354478/-/commit/4d...

E.g. in composer.json under extras patches insert:

"drupal/permissions_by_term": {
  "Fix Twig regression patch": "https://git.drupalcode.org/issue/permissions_by_term-3354478/-/commit/4daf422f379585da550a05d23d4c77aa8dc328ca.diff"
}

Thanks for Patch: https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/....

Worked with D9.5.5

@fathima.asmat Would you please take a look on this?

Patch https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/... worked for me too on D 9.5.9

Interesting finding: the issue only exists on our production environment. I've dumped the database from live for local investigation but cannot reproduce it locally.

Thanks for Patch: https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/....

Worked with D9.5.8

I ran into a similar issue in 🐛 Fatal error from Twig when creating default target module in Drupal 10 Fixed where another maintainer had previously used the same Twig loadTemplate() method and it failed spectacularly when moving to Drupal 10, which bumped the major Twig version from 2 to 3 and the method changed. While the merge request is a definite improvement, I'm a bit baffled about why the template file is still left in the src/View, or why it was put there in the first place, when it should be under a templates directory. If the problem is that it could conflict with other templates, then name it something like permissions-by-term-node-details.html.twig and then just reference the template name without having to grab the path. That way it's possible for a theme or other module to build on the template and it keeps things tidy and where they should live.

#3354478-14: Regression updating to 3.1.22 for Drupal 9.x using loadTemplate from twig → works

I think it is necessary to update the module immediately with this patch.

While https://www.drupal.org/project/permissions_by_term/issues/3354478#commen... 🐛 Regression updating to 3.1.22 for Drupal 9.x using loadTemplate from twig Fixed is a valid remark, I think a release including the patch should be prioritized to get the regression fixed.

Rethinking / renaming the template can be done as a followup task.

Hello,
I tested https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/... patch and it works, but generate error in JS after select something, like on the screen.

I created a fix including a item type element: https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/...

Thanks @adrianliegmann - I've run into the same issue and applied the latest merge request (#25) and all seems to work perfectly fine now.

After upgrading to permissions_by_term to 3.1.22 and applying the patch https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/...

I see JS error

@srinivasraod I believe you did not apply the right patch. Can you try this one?

https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/...

@LeDucDuBleuet Thank you!!
#30 worked for me

@srinivasraod Great, glad I could help!

So I also reviewed and tested the merge request !25 with success and I think it is safe to put this issue to RTBC.

Thanks!

3.1.22 breaks functionality also in my case with drupal 9.5.10. Cannot review the proposed solution because there is no patch provided here.

It's been over a month since a working patch was posted. Is one of the maintainers available to get this patch released?

Fixed in 3.1.24

Automatically closed - issue fixed for 2 weeks with no activity.