[random test failure] Try to un-skip and fix BlockFormMessagesTest::testValidationMessage() in context of [#3353085]

Created on 9 April 2023, over 1 year ago
Updated 24 April 2023, over 1 year ago

Problem/Motivation

In πŸ› [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() Fixed @nod_ introduced a "fix" for problems with the correct opening of an off-canvas dialog which potentially could fix all JS random test failures for tests using the drupal.dialog.off_canvas somehow.

The basic test is:

  1. Unskip BlockFormMessagesTest::testValidationMessage().
  2. Run _only_ now unskipped BlockFormMessagesTest::testValidationMessage() a lot of times () as-is.
  3. Run _only_ now unskipped BlockFormMessagesTest::testValidationMessage() a lot of times () _without_ the changes in πŸ› [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() Fixed .
  4. If 2., passes and 3. doesn't, we can safely turn the test back on again.

Per @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests β†’ we now need to go for a 5000-8000 times run for both patches.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

9.5

Component
Layout builderΒ  β†’

Last updated 6 days ago

Created by

πŸ‡³πŸ‡±Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024