[11.x] Update doctrine/annotations to v2

Adding a parent. I will note over there that this is still in discussion.

Seems this one had build errors

Per 📌 Use PHP attributes instead of doctrine annotations Fixed we won't remove annotations support in Drupal 11, although we should be able to fully deprecate it, so we should go ahead here.

Searched for AnnotationRegistry::registerLoader and 3 instances were replaced. Doesn't seem to have caused any failures

Marking this as 11.x only, as we prefer not to bump major versions of dependencies in a minor release, and if we did we should try to add compatibility for both versions at once - not impossible but let's save the effort if we can.

This is listed under "add a compatibility layer to Drupal 10" in 🌱 [meta] Add compatibility for the latest major and minor versions of dependencies to Drupal 10 Active , do you think that is not needed @longwave? If so, that should be moved to reference from the updates to be done in the 11.x branch and not from the "prepare Drupal 10" issue.

Not much to shim IMHO.

AnnotationRegistry::registerLoader is removed, but that seems only been used in /vendor of contrib:
https://git.drupalcode.org/search?group_id=2&scope=blobs&search=%22Annot...

Same for AnnotationRegistry::registerAutoloadNamespace:
https://git.drupalcode.org/search?group_id=2&scope=blobs&search=%22Annot...

Yeah I don't think any compatibility layer is needed, if anyone was using doctrine/annotations directly (which seems fairly unlikely) they may have to make minor changes as part of the D10-11 cycle, but the APIs that we provide on top are unchanged.

So are we OK with moving this issue from 🌱 [meta] Add compatibility for the latest major and minor versions of dependencies to Drupal 10 Active to 🌱 [11.x] [meta] Requirements for tagging 11.0.0-alpha1 Active ?

The parent of this issue is already 🌱 [meta] Requirements for tagging Drupal 11.0.0-beta1 Active , I updated 🌱 [meta] Add compatibility for the latest major and minor versions of dependencies to Drupal 10 Active to remove doctrine/annotations.

Thanks, the latter is what I tried to ask, but failed miserably at (too many METAs!!! ;)

Thanks @longwave!

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

11.x is open for 11.0.x changes AFAIK, so this is at least NR, maybe even RTBC, since I only did a rebase since the last RTBC.

Rebase seems good, so going to put back in RTBC.

Committed/pushed to 11.x, thanks!

Spokje → closed merge request !6450

Automatically closed - issue fixed for 2 weeks with no activity.