- Issue created by @spokje
- @spokje opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:11pm 29 March 2023 - Status changed to Needs work
over 1 year ago 6:16pm 29 March 2023 - Status changed to Needs review
over 1 year ago 6:28pm 29 March 2023 - Status changed to RTBC
over 1 year ago 6:44pm 29 March 2023 - π³π±Netherlands daffie
All my remarks have been addressed.
For me it is RTBC. - π³π±Netherlands spokje
Rebased after π Fix PHPStan L1 errors "@covers value \Foo\Bar::baz() references an invalid method." Fixed was committed.
- π³π±Netherlands spokje
Rebased after π Fix PHPStan L1 errors "Annotation "@covers::foo" is invalid, "@covers" should be followed by a space and a value." Fixed was committed.
NOTE: There's still one open thread in the MR that might(?) need some more input before committing.
- Status changed to Needs work
over 1 year ago 5:44pm 11 April 2023 - Status changed to Needs review
over 1 year ago 8:27am 12 April 2023 - Status changed to RTBC
over 1 year ago 4:41pm 12 April 2023 - π³π±Netherlands daffie
All the changes look good to me.
Back to RTBC. - π³π±Netherlands spokje
Merge blocked: fast-forward merge is not possible. To merge this request, first rebase locally.
- Assigned to spokje
- Status changed to Needs work
over 1 year ago 6:51pm 12 April 2023 - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 7:37pm 12 April 2023 - last update
over 1 year ago 29,202 pass -
longwave β
committed 99492c02 on 10.1.x
Issue #3351095 by Spokje, daffie, longwave, xjm: Fix PHPStan L1 errors...
-
longwave β
committed 99492c02 on 10.1.x
- π¬π§United Kingdom longwave UK
Committed and pushed to 10.1.x, thanks!
- Status changed to Fixed
over 1 year ago 6:34am 1 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.